chore: bump kurtosis-cdk version to support pre-deployed gas token #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
approved these changes
Nov 27, 2024
|
I'm afraid the SonarCloud job won't pass because I'm opening a PR from an external fork. Is this a blocker for the PR to be merged? |
Nope, it is a known issue and you have not affected the source code, therefore it could not have negatively impacted the SonarCloud. |
joanestebanr
added a commit
that referenced
this pull request
Dec 2, 2024
… certificates in a history table (#208) - Add new field `retries` to database, that keep the count of times of regenerated the certificate - The discarded certificates are move (if configuration allow that) to a new table `certificate_info_history` - Cherry-picked #202 to fix e2e-test ## Configuration ``` [AggSender] KeepCertificatesHistory = true ``` --------- Co-authored-by: Léo Vincent <[email protected]> Co-authored-by: Toni Ramírez <[email protected]> Co-authored-by: Stefan Negovanović <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to 0xPolygon/kurtosis-cdk#386
It looks like the CI doesn't run the e2e tests on my PR, maybe because it comes from an external fork? I've created a local PR on my fork to make sure they all pass. Note that the fork12-pp test doesn't pass on the
developbranch either.