-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: improve deploy workflows #207
Closed
leovct
wants to merge
36
commits into
0xPolygon:vcastellm/use-cdk
from
leovct:debug/vcastell-use-cdk-2
Closed
ci: improve deploy workflows #207
leovct
wants to merge
36
commits into
0xPolygon:vcastellm/use-cdk
from
leovct:debug/vcastell-use-cdk-2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leovct
force-pushed
the
debug/vcastell-use-cdk-2
branch
from
August 6, 2024 08:49
a80f933
to
f1cb76c
Compare
…pt instead + refactor the monitor script
…en deploying cdk
…vcastell-use-cdk-2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Find out why batches are not being verified
Erigon Setup
When deploying the CDK stack locally, we can see that the number of verified batches increases. The problem may come from the monitor script.
Looking at the CI job, it seems that the monitor script is stuck after the first request. There is a problem with the
cast send
.It turns out the
cast send
cmd used to increase the number of batches is not handled properly by the new erigon node. We found a fix by reducing the gas limit used to100000
instead of643528
. It looks like this a regression from the legacy node.ZkEVM setup
There were couple of things:
zkevm-node
as the sequencer type instead ofzkevm
.Couple of quality of life improvements
deploy
jobs by settingl1_seconds_per_slot
to1
s instead of12
s.deploy
jobs - 20 minutes timeout.monitor-cdk-verified-batches
local action into a script. Imo, it's easier to use and maintain.monitor-verified-batches.sh
script.References (if applicable)
https://0xpolygon.slack.com/archives/C060ZAVAU9K/p1722846740784669