Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve deploy workflows #207

Closed

Conversation

leovct
Copy link
Member

@leovct leovct commented Aug 6, 2024

Description

Find out why batches are not being verified

Erigon Setup

When deploying the CDK stack locally, we can see that the number of verified batches increases. The problem may come from the monitor script.

Screenshot 2024-08-06 at 12 10 17

Looking at the CI job, it seems that the monitor script is stuck after the first request. There is a problem with the cast send.

Screenshot 2024-08-06 at 13 06 17

It turns out the cast send cmd used to increase the number of batches is not handled properly by the new erigon node. We found a fix by reducing the gas limit used to 100000 instead of 643528 . It looks like this a regression from the legacy node.

ZkEVM setup

There were couple of things:

  • A typo in the prover configuration and the same typo in the zkevm node library where we use zkevm-node as the sequencer type instead of zkevm.
  • The zkevm sequence-sender is deployed twice.

Couple of quality of life improvements

  • Speed up the deploy jobs by setting l1_seconds_per_slot to 1s instead of 12s.
  • Add timeouts to each job, especially the deploy jobs - 20 minutes timeout.
  • Transform the monitor-cdk-verified-batches local action into a script. Imo, it's easier to use and maintain.
  • Improve the monitor-verified-batches.sh script.
    • It now requires an RPC URL instead of the name of the rpc service to query. This flag is mandatory.
    • It shows the script input values for debug purposes.
    • It shows the different batch counters (latest batch number on L2, virtual and verified batches).

References (if applicable)

https://0xpolygon.slack.com/archives/C060ZAVAU9K/p1722846740784669

@leovct leovct force-pushed the debug/vcastell-use-cdk-2 branch from a80f933 to f1cb76c Compare August 6, 2024 08:49
@leovct leovct changed the title debug: vcastell/use-cdk ci issue ci: improve deploy workflows Aug 6, 2024
@leovct leovct deleted the branch 0xPolygon:vcastellm/use-cdk August 6, 2024 16:19
@leovct leovct closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant