Fork ID Upgrading Notes #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -8,15 +8,23 @@ deployment_suffix: "-001" | |||
| # The deployment process is divided into various stages. | |||
| # The `stages` parameter indicates the specific stages you wish the deployment to proceed through. | |||
| # By default, it will execute all the stages. | |||
| stages: [1, 2, 3, 4, 5] | |||
| stages: [1, 2, 2.5, 3, 4, 5] | |||
There was a problem hiding this comment.
Is this how you intended this to work @leovct lol
leovct
approved these changes
Mar 27, 2024
| @@ -8,15 +8,23 @@ deployment_suffix: "-001" | |||
| # The deployment process is divided into various stages. | |||
| # The `stages` parameter indicates the specific stages you wish the deployment to proceed through. | |||
| # By default, it will execute all the stages. | |||
| stages: [1, 2, 3, 4, 5] | |||
| stages: [1, 2, 2.5, 3, 4, 5] | |||
There was a problem hiding this comment.
I think we should use integer numbers rather than decimal numbers, what do you think? And I'm thinking of adding the description of each stages in params.yml and also updating this section of the readme: https://github.com/0xPolygon/kurtosis-cdk?tab=readme-ov-file#for-developers.
Suggested change
| stages: [1, 2, 2.5, 3, 4, 5] | |
| stages: [1, 2, 3, 4, 5, 6] |
leovct
reviewed
Mar 27, 2024
| # The `stages` parameter indicates the specific stages you wish the deployment to proceed through. | ||
| # By default, it will execute all the stages. | ||
| -stages: [1, 2, 3, 4, 5] | ||
| +stages: [3] |
There was a problem hiding this comment.
Glad to see you're using the stage feature :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly a documentation commit, but there are also some minor changes to the staged process that @leovct put together in order to separate the creation of the database from the actual services starting. Those are now in stage 2.5.