Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add token doc to docs platform #76

Merged
merged 12 commits into from
Apr 23, 2024
Merged

docs: Add token doc to docs platform #76

merged 12 commits into from
Apr 23, 2024

Conversation

kmurphypolygon
Copy link
Contributor

Description

This PR adds the gas token documentation from the docs-draft folder into the knowledge layer docs.

@praetoriansentry
Copy link
Member

fyi @leovct a little surprised to see the CI fail here

@leovct
Copy link
Member

leovct commented Apr 22, 2024

fyi @leovct a little surprised to see the CI fail here

I tried to debug, it's a bit weird...

This happened because this morning I updated my zkevm-contracts fork with the latest changes from upstream and built/pushed the docker images. So our CI pulled the latest images with the latest foundry version which I think is the culprit.

I had to revert to a quite old foundry version to be able to send the transaction...

$ foundryup
$ cast --version
cast 0.2.0 (63fff35 2024-04-22T00:25:29.695811000Z)
$ cast send --rpc-url "http://127.0.0.1:59288" --mnemonic "code code code code code code code code code code code quality" --value 0 "0x5b06837A43bdC3dD9F114558DAf4B26ed49842Ed"
Error: 
deserialization error: invalid number at line 1 column 269

Context:
- invalid number at line 1 column 269

$ foundryup --version nightly-f625d0fa7c51e65b4bf1e8f7931cd1c6e2e285e9
$ cast --version
cast 0.2.0 (f625d0f 2024-04-02T00:16:42.803795000Z)
$ cast send --rpc-url "http://127.0.0.1:59288" --mnemonic "code code code code code code code code code code code quality" --value 0 "0x5b06837A43bdC3dD9F114558DAf4B26ed49842Ed"

blockHash               0x5e433d39745db064f8963e3f807f2ed25f2f900a757f94dfcf2f678a60cde3b4
blockNumber             652
contractAddress         
cumulativeGasUsed       21000
effectiveGasPrice       3000000007
from                    0x85dA99c8a7C2C95964c8EfD687E95E632Fc533D6
gasUsed                 21000
logs                    []
logsBloom               0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
root                    
status                  1
transactionHash         0xd26eca7fe814ea518ec1efcbd9f0c08136eec52af03ab8a8e4f79391ae560d8c
transactionIndex        0
type                    2
to                      0x5b06837A43bdC3dD9F114558DAf4B26ed49842Ed

But when I tried locally against a local anvil node, it worked well with the latest version...

$ anvil &
$ cast --version
cast 0.2.0 (63fff35 2024-04-22T00:25:29.695811000Z)
$ cast send --rpc-url "http://127.0.0.1:8545" --mnemonic "test test test test test test test test test test test junk" --value 0 "0x5b06837A43bdC3dD9F114558DAf4B26ed49842Ed"

blockHash               0x99312f72574c9240015bbb23b2c6776176437f22a38d0bf1bf6c2550045399b7
blockNumber             1
contractAddress         
cumulativeGasUsed       21000
effectiveGasPrice       1000000000
from                    0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266
gasUsed                 21000
logs                    []
logsBloom               0x00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000
root                    
status                  1 (success)
transactionHash         0xaa76c3d54aaa876967564f39090ff53fa32a436575b7e5c5e247e23b1f7d4de8
transactionIndex        0
type                    2
blobGasPrice            
blobGasUsed             
to                      0x5b06837A43bdC3dD9F114558DAf4B26ed49842Ed
depositNonce             null

A temporary solution would be to use a specific foundry version, I'm rebuilding the images at the moment.

https://github.com/leovct/zkevm-contracts/actions/runs/8790044552

Copy link
Member

@leovct leovct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a few comments :)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kmurphypolygon kmurphypolygon merged commit 1f36fec into main Apr 23, 2024
5 checks passed
@kmurphypolygon kmurphypolygon deleted the docs/token branch April 23, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants