option to reject transactions with a low gas price (#1539)

when compared to the response from eth_gasPrice
0xPolygonHermez · Dec 4, 2024 · feca211 · feca211
1 parent 9634f40
commit feca211
Show file tree

Hide file tree

Showing 6 changed files with 60 additions and 35 deletions.
diff --git a/cmd/rpcdaemon/commands/eth_api.go b/cmd/rpcdaemon/commands/eth_api.go
@@ -331,23 +331,24 @@ func (api *BaseAPI) pruneMode(tx kv.Tx) (*prune.Mode, error) {
 // APIImpl is implementation of the EthAPI interface based on remote Db access
 type APIImpl struct {
 	*BaseAPI
-	ethBackend                  rpchelper.ApiBackend
-	txPool                      txpool.TxpoolClient
-	mining                      txpool.MiningClient
-	gasCache                    *GasPriceCache
-	db                          kv.RoDB
-	GasCap                      uint64
-	ReturnDataLimit             int
-	ZkRpcUrl                    string
-	PoolManagerUrl              string
-	AllowFreeTransactions       bool
-	AllowPreEIP155Transactions  bool
-	L1RpcUrl                    string
-	DefaultGasPrice             uint64
-	MaxGasPrice                 uint64
-	GasPriceFactor              float64
-	L1GasPrice                  L1GasPrice
-	VirtualCountersSmtReduction float64
+	ethBackend                    rpchelper.ApiBackend
+	txPool                        txpool.TxpoolClient
+	mining                        txpool.MiningClient
+	gasCache                      *GasPriceCache
+	db                            kv.RoDB
+	GasCap                        uint64
+	ReturnDataLimit               int
+	ZkRpcUrl                      string
+	PoolManagerUrl                string
+	AllowFreeTransactions         bool
+	AllowPreEIP155Transactions    bool
+	L1RpcUrl                      string
+	DefaultGasPrice               uint64
+	MaxGasPrice                   uint64
+	GasPriceFactor                float64
+	L1GasPrice                    L1GasPrice
+	VirtualCountersSmtReduction   float64
+	RejectLowGasPriceTransactions bool
 }
 
 // NewEthAPI returns APIImpl instance
@@ -357,24 +358,25 @@ func NewEthAPI(base *BaseAPI, db kv.RoDB, eth rpchelper.ApiBackend, txPool txpoo
 	}
 
 	return &APIImpl{
-		BaseAPI:                     base,
-		db:                          db,
-		ethBackend:                  eth,
-		txPool:                      txPool,
-		mining:                      mining,
-		gasCache:                    NewGasPriceCache(),
-		GasCap:                      gascap,
-		ReturnDataLimit:             returnDataLimit,
-		ZkRpcUrl:                    ethCfg.L2RpcUrl,
-		PoolManagerUrl:              ethCfg.PoolManagerUrl,
-		AllowFreeTransactions:       ethCfg.AllowFreeTransactions,
-		AllowPreEIP155Transactions:  ethCfg.AllowPreEIP155Transactions,
-		L1RpcUrl:                    ethCfg.L1RpcUrl,
-		DefaultGasPrice:             ethCfg.DefaultGasPrice,
-		MaxGasPrice:                 ethCfg.MaxGasPrice,
-		GasPriceFactor:              ethCfg.GasPriceFactor,
-		L1GasPrice:                  L1GasPrice{},
-		VirtualCountersSmtReduction: ethCfg.VirtualCountersSmtReduction,
+		BaseAPI:                       base,
+		db:                            db,
+		ethBackend:                    eth,
+		txPool:                        txPool,
+		mining:                        mining,
+		gasCache:                      NewGasPriceCache(),
+		GasCap:                        gascap,
+		ReturnDataLimit:               returnDataLimit,
+		ZkRpcUrl:                      ethCfg.L2RpcUrl,
+		PoolManagerUrl:                ethCfg.PoolManagerUrl,
+		AllowFreeTransactions:         ethCfg.AllowFreeTransactions,
+		AllowPreEIP155Transactions:    ethCfg.AllowPreEIP155Transactions,
+		L1RpcUrl:                      ethCfg.L1RpcUrl,
+		DefaultGasPrice:               ethCfg.DefaultGasPrice,
+		MaxGasPrice:                   ethCfg.MaxGasPrice,
+		GasPriceFactor:                ethCfg.GasPriceFactor,
+		L1GasPrice:                    L1GasPrice{},
+		VirtualCountersSmtReduction:   ethCfg.VirtualCountersSmtReduction,
+		RejectLowGasPriceTransactions: ethCfg.RejectLowGasPriceTransactions,
 	}
 }
 

diff --git a/cmd/rpcdaemon/commands/send_transaction.go b/cmd/rpcdaemon/commands/send_transaction.go
@@ -10,6 +10,7 @@ import (
 	"github.com/gateway-fm/cdk-erigon-lib/common"
 	"github.com/gateway-fm/cdk-erigon-lib/common/hexutility"
 	txPoolProto "github.com/gateway-fm/cdk-erigon-lib/gointerfaces/txpool"
+	"github.com/holiman/uint256"
 	"github.com/ledgerwatch/erigon/core/types"
 	"github.com/ledgerwatch/erigon/eth/ethconfig"
 	"github.com/ledgerwatch/erigon/params"
@@ -49,6 +50,20 @@ func (api *APIImpl) SendRawTransaction(ctx context.Context, encodedTx hexutility
 		return common.Hash{}, err
 	}
 
+	// check if the transaction price is lower than the current network price and
+	// reject the tx if it is
+	if api.RejectLowGasPriceTransactions && !api.BaseAPI.gasless {
+		txnPrice := txn.GetPrice()
+		networkPrice, err := api.GasPrice_nonRedirected(ctx)
+		if err != nil {
+			return common.Hash{}, err
+		}
+		networkPrice256, _ := uint256.FromBig(networkPrice.ToInt())
+		if txnPrice.Cmp(networkPrice256) < 0 {
+			return common.Hash{}, fmt.Errorf("transaction price is lower than the current network price")
+		}
+	}
+
 	if txn.Type() != types.LegacyTxType {
 		latestBlock, err := api.blockByNumber(ctx, rpc.LatestBlockNumber, tx)
 

diff --git a/cmd/utils/flags.go b/cmd/utils/flags.go
@@ -693,6 +693,11 @@ var (
 		Usage: "Mock the witness generation",
 		Value: false,
 	}
+	RejectLowGasPriceTransactions = cli.BoolFlag{
+		Name:  "zkevm.reject-low-gas-price-transactions",
+		Usage: "Reject transactions with a gas price lower than the current network price",
+		Value: false,
+	}
 	ACLPrintHistory = cli.IntFlag{
 		Name:  "acl.print-history",
 		Usage: "Number of entries to print from the ACL history on node start up",

diff --git a/eth/ethconfig/config_zkevm.go b/eth/ethconfig/config_zkevm.go
@@ -87,6 +87,7 @@ type Zk struct {
 	BadBatches                     []uint64
 	SealBatchImmediatelyOnOverflow bool
 	MockWitnessGeneration          bool
+	RejectLowGasPriceTransactions  bool
 }
 
 var DefaultZkConfig = &Zk{}

diff --git a/turbo/cli/default_flags.go b/turbo/cli/default_flags.go
@@ -240,4 +240,5 @@ var DefaultFlags = []cli.Flag{
 	&utils.BadBatches,
 	&utils.SealBatchImmediatelyOnOverflow,
 	&utils.MockWitnessGeneration,
+	&utils.RejectLowGasPriceTransactions,
 }
diff --git a/turbo/cli/flags_zkevm.go b/turbo/cli/flags_zkevm.go
@@ -196,6 +196,7 @@ func ApplyFlagsForZkConfig(ctx *cli.Context, cfg *ethconfig.Config) {
 		BadBatches:                     badBatches,
 		SealBatchImmediatelyOnOverflow: ctx.Bool(utils.SealBatchImmediatelyOnOverflow.Name),
 		MockWitnessGeneration:          ctx.Bool(utils.MockWitnessGeneration.Name),
+		RejectLowGasPriceTransactions:  ctx.Bool(utils.RejectLowGasPriceTransactions.Name),
 	}
 
 	utils2.EnableTimer(cfg.DebugTimers)