Refactor/encryption key #469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # lib/common/kms/key_providers/bjj_provider.dart # lib/common/kms/key_providers/ed25519_provider.dart # lib/common/kms/key_providers/secp256k1_provider.dart # lib/iden3comm/authenticate.dart # lib/iden3comm/domain/use_cases/fetch_and_save_claims_use_case.dart # lib/iden3comm/domain/use_cases/fetch_onchain_claims_use_case.dart # lib/iden3comm/domain/use_cases/get_auth_inputs_use_case.dart # lib/identity/data/data_sources/smt_data_source.dart # lib/identity/data/data_sources/storage_smt_data_source.dart # lib/identity/data/repositories/identity_repository_impl.dart # lib/identity/data/repositories/smt_repository_impl.dart # lib/identity/domain/use_cases/identity/update_identity_use_case.dart # lib/identity/libs/bjj/bjj_wallet.dart # lib/identity/libs/bjj/eddsa_babyjub.dart # lib/sdk/di/injector.config.dart # lib/sdk/di/injector.dart # lib/sdk/polygon_id_sdk.dart # pubspec.yaml # test/common/kms.dart # test/identity/domain/use_cases/profile/add_profile_use_case_test.dart # test/identity/domain/use_cases/profile/remove_profile_use_case_test.dart
# Conflicts: # lib/sdk/di/injector.config.dart
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #469 +/- ##
===========================================
- Coverage 21.96% 21.40% -0.56%
===========================================
Files 257 265 +8
Lines 8474 8605 +131
===========================================
- Hits 1861 1842 -19
- Misses 6613 6763 +150 ☔ View full report in Codecov by Sentry. |
plusema86
reviewed
Jan 20, 2025
| @@ -45,7 +45,7 @@ class UpdateClaimUseCase extends FutureUseCase<UpdateClaimParam, ClaimEntity> { | |||
| .getClaim( | |||
| claimId: param.id, | |||
| genesisDid: param.genesisDid, | |||
| privateKey: param.privateKey) | |||
| encryptionKey: param.encryptionKey) | |||
| .then((claim) => ClaimEntity( | |||
There was a problem hiding this comment.
if possible can we remove the usage of multiple then like you did in other places? IMHO it is easier to debug and read, but we can do it at a later stage.
plusema86
approved these changes
Jan 20, 2025
# Conflicts: # lib/sdk/di/injector.config.dart
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.