Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added crosschain proof data retrieval function. #470

Merged
merged 3 commits into from
Jan 20, 2025

Conversation

5eeman
Copy link
Contributor

@5eeman 5eeman commented Jan 17, 2025

No description provided.

@5eeman 5eeman requested a review from plusema86 January 17, 2025 11:56
@5eeman 5eeman self-assigned this Jan 17, 2025
@5eeman 5eeman marked this pull request as ready for review January 17, 2025 15:08
@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.50505% with 197 lines in your changes missing coverage. Please review.

Project coverage is 21.96%. Comparing base (70076d7) to head (2cbd6af).
Report is 26 commits behind head on develop.

Files with missing lines Patch % Lines
lib/proof/data/dtos/universal_resolver_entity.dart 0.00% 64 Missing ⚠️
...roof/domain/entities/generate_inputs_response.dart 3.12% 31 Missing ⚠️
...proof/data/repositories/crosschain_repository.dart 0.00% 29 Missing ⚠️
...n/use_cases/generate_iden3comm_proof_use_case.dart 0.00% 15 Missing ⚠️
.../data_sources/crosschain_resolver_data_source.dart 0.00% 15 Missing ⚠️
lib/iden3comm/authenticate.dart 0.00% 10 Missing ⚠️
lib/common/utils/hex_utils.dart 0.00% 9 Missing ⚠️
lib/sdk/polygonid_flutter_channel.dart 0.00% 8 Missing ⚠️
...ties/proof/response/iden3comm_sd_proof_entity.dart 0.00% 7 Missing ⚠️
...ntities/proof/response/iden3comm_proof_entity.dart 0.00% 5 Missing ⚠️
... and 2 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #470      +/-   ##
===========================================
- Coverage    22.84%   21.96%   -0.89%     
===========================================
  Files          250      257       +7     
  Lines         8136     8474     +338     
===========================================
+ Hits          1859     1861       +2     
- Misses        6277     6613     +336     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@plusema86 plusema86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably I need a sharing knowledge session about the topic

@5eeman 5eeman merged commit 7108bdf into develop Jan 20, 2025
2 checks passed
@5eeman 5eeman deleted the feature/crosschain_resolver branch January 20, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants