chore: add changelog and address comments

0xPolygonMiden · Jan 6, 2025 · 8bf8997 · 8bf8997
1 parent 4e31547
commit 8bf8997
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,6 +5,7 @@
 - [BREAKING] Updated Winterfell dependency to v0.11 (#346).
 - Added RPO-STARK based DSA (#349).
 - Added benchmarks for DSA implementations (#354).
+- Implemented deterministic RPO-STARK based DSA (#358).
 
 ## 0.12.0 (2024-10-30)
 

diff --git a/src/dsa/rpo_stark/stark/mod.rs b/src/dsa/rpo_stark/stark/mod.rs
@@ -2,9 +2,8 @@ use alloc::vec::Vec;
 use core::marker::PhantomData;
 
 use prover::RpoSignatureProver;
-use rand::{distributions::Standard, prelude::Distribution};
 use rand_chacha::ChaCha20Rng;
-use winter_crypto::{ElementHasher, Hasher, SaltedMerkleTree};
+use winter_crypto::{ElementHasher, SaltedMerkleTree};
 use winter_math::fields::f64::BaseElement;
 use winter_prover::{Proof, ProofOptions, Prover};
 use winter_utils::Serializable;
@@ -26,10 +25,7 @@ pub struct RpoSignatureScheme<H: ElementHasher> {
     _h: PhantomData<H>,
 }
 
-impl<H: ElementHasher<BaseField = BaseElement> + Sync> RpoSignatureScheme<H>
-where
-    Standard: Distribution<<H as Hasher>::Digest>,
-{
+impl<H: ElementHasher<BaseField = BaseElement> + Sync> RpoSignatureScheme<H> {
     pub fn new(options: ProofOptions) -> Self {
         RpoSignatureScheme { options, _h: PhantomData }
     }