Add get_insert_witness() method to TSMT
#211
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpo: added conversions for digest
RPX hash function
mmr: publicly export MmrDelta
mmr: support arbitrary from/to delta updates
…r-versions mmr: support proofs with older forest versions
Bump winterfell release to .7
bobbinth
reviewed
Nov 1, 2023
bobbinth
reviewed
Nov 1, 2023
bobbinth
reviewed
Nov 1, 2023
bobbinth
requested changes
Nov 3, 2023
Comment on lines
+422
to
+425
| pub struct TieredSmtInsertWitness { | ||
| pub partial_mt: PartialMerkleTree, | ||
| pub advice_map: BTreeMap<RpoDigest, Vec<(RpoDigest, Word)>>, | ||
| } |
There was a problem hiding this comment.
Following this comment, I wonder if instead of returning a PartialMerkleTree we return just Vec<MerklePath>. Then, this struct could look something like this:
pub struct TieredSmtInsertWitness {
pub paths: Vec<MerklePath>,
pub indexes: Vec<NodeIndex>,
pub leaves: BTreeMap<RpoDigest, Vec<(RpoDigest, Word)>>,
}
|
Kudos, SonarCloud Quality Gate passed!
|
plafer
changed the title
preinsert_partial_merkle_tree() method to TSMTget_insert_witness() method to TSMT
|
Closing this as we are removing TSMT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.