Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mmr: add into_parts for the peaks #214

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Conversation

hackaugusto
Copy link
Contributor

Describe your changes

Allows one to consume the object and get a hand of the peaks vector.

Checklist before requesting a review

  • Repo forked and branch created from next according to naming convention.
  • Commit messages and codestyle follow conventions.
  • Relevant issues are linked in the PR description.
  • Tests added for new functionality.
  • Documentation/comments updated according to changes.

@hackaugusto hackaugusto requested a review from bobbinth November 2, 2023 18:57
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a small non-blocking comment inline.

@@ -54,6 +54,11 @@ impl MmrPeaks {
&self.peaks
}

/// Returns the current peaks of the [Mmr].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should the comment also mention num_leaves?

@hackaugusto hackaugusto force-pushed the hacka-mmr-peaks-into-parts branch from b5a0e25 to e4c3367 Compare November 3, 2023 10:57
Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@hackaugusto hackaugusto merged commit b677952 into next Nov 3, 2023
11 checks passed
@hackaugusto hackaugusto deleted the hacka-mmr-peaks-into-parts branch November 3, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants