Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MmrPeaks::hash_peaks() returns RpoDigest #230

Merged
merged 1 commit into from
Nov 28, 2023
Merged

MmrPeaks::hash_peaks() returns RpoDigest #230

merged 1 commit into from
Nov 28, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Nov 28, 2023 •
edited
Loading

RpoDigest is more flexible than Word. Specifically, I need the conversion to [u8; 32] from RpoDigest when using AdviceInputs.map.

Also, returning Word loses the information that the Word encodes an RpoDigest as opposed to any other digest.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

bobbinth
bobbinth approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@plafer plafer merged commit e87f98d into next Nov 28, 2023
11 checks passed
@plafer plafer deleted the plafer-mmrpeaks-hash_peaks branch November 28, 2023 21:45
This was referenced Nov 28, 2023
Closed
Merged
@Fumuran Fumuran mentioned this pull request Nov 28, 2023
Merged
bobbinth pushed a commit that referenced this pull request Dec 21, 2023
@plafer @bobbinth
MmrPeaks::hash_peaks() returns Digest (#230)
29e0d07
bobbinth pushed a commit that referenced this pull request Feb 14, 2024
@plafer @bobbinth
MmrPeaks::hash_peaks() returns Digest (#230)
18310a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

@hackaugusto hackaugusto Awaiting requested review from hackaugusto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plafer @bobbinth