Fix TSMT serialization #235
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rpo: added conversions for digest
RPX hash function
mmr: publicly export MmrDelta
mmr: support arbitrary from/to delta updates
…r-versions mmr: support proofs with older forest versions
Bump winterfell release to .7
…-forest mmr: support accumulator of older forest versions
When a prefix is pushed to the depth 64, the entry list includes only the values different than ZERO. This is required, since each block represents a 2^192 values. The bug was in the proof membership code, that failed to handle the case of a key that was not in the list, because the depth is 64 and the value was not set.
…ic-data simple_smt: reduce serialized size, use static hashes of the empty word
mmr: add into_parts for the peaks
Implement `IntoIterator` for `RpoDigest`
feat: memoize Signature polynomial decoding
…ndex-bug simplesmt: bugfix, index must be validated before modifying the tree
…duplicate-check simplesmt: simplify duplicate check
…#228) * Change InvalidNumEntries error * max computation * remove length check * remove ExactSizeIterator constraint * fix InvalidNumEntries error condition * 2_usize
…value-depth-64 bugfix: TSMT failed to verify empty word for depth 64.
serde: for MerklePath, ValuePath, and RootPath
|
|
In what context do we need this serialization? Originally, it was meant to be used only for mock data purposes. |
|
I can't speak for why it was added in the first place, but I implemented this to be able to serialize an However with 0xPolygonMiden/miden-base#369 we no longer need this change (for the purpose of |
|
Actually maybe it would be better to import the serialization strategy from that PR - see 0xPolygonMiden/miden-base#369 (comment) |
|
Closing this as we re removing TSMT. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current serde serialization of
NodeIndexmakes serializing data structures that contain aHashMap<NodeIndex, ...>fail with the error:"key must be a string"(more details here).This implements a workaround:
NodeIndexis serialized as"depth-value".