Update RPO's padding rule to use that in the xHash paper #318
Conversation
CHANGELOG.md
Outdated
| ## 0.10.0 (TBD) | ||
|
|
||
| * Added more `RpoDigest` and `RpxDigest` conversions (#311). | ||
| * Migrated to Winterfell v0.9.0 (#315) | ||
|
|
There was a problem hiding this comment.
We should probably rebase this PR from the latest next to make sure we carry over the latest updates.
|
There was a problem hiding this comment.
Looks good! Thank you! Let's hold off on merging this until we propagate the changes to miden-base.
On potential thing left to consider: I believe currently hashing of empty list of elements and hashing of 8 ZERO elements will give us the same result - right? I wonder if there is a good way to fix this - just in case. Nothing immediately comes to mind though.
I think we had a similar discussion in RPO and I believe we settled on not accepting empty lists for hashing. I will think about it again to see if we can accommodate it differently. |
|
@Al-Kindi-0 - let's rebase this PR. Also, should we implement the rule where hashing of an empty string gives us |
Al-Kindi-0
force-pushed
the
al-rpo-new-padding-rule
branch
from
74a343c to
32c877e
Compare
Done! |
This reverts commit 568b458.
doc: add padding comment on RPO new padding rule
Al-Kindi-0
force-pushed
the
al-rpo-new-padding-rule
branch
from
32c877e to
e6222dd
Compare
There was a problem hiding this comment.
Looks good! Thank you! I left a few small comments inline.
Also, it seems like the "return default digest on empty input" as already working here, right?
Lastly, could you refresh 0xPolygonMiden/miden-vm#1343 when you get a chance?
Yes, had to check the bytes case, but even then it worked without complications
Sure thing |
…rypto into al-rpo-new-padding-rule
|
|
Describe your changes
Checklist before requesting a review
nextaccording to naming convention.