feat: Add size hint for digests #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Sep 25, 2024
PhilippGackstatter
force-pushed
the
pgackst-digest-size-hint
branch
from
f2d203c to
2b71ec5
Compare
bobbinth
reviewed
Sep 25, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds a
get_size_hintimplementation forRpoDigestandRpxDigest. This is required to nicely implementget_size_hintfor custom types in miden-base, see also: 0xPolygonMiden/miden-base#895.The added tests currently fail, but once facebook/winterfell#332 is merged, they no longer will.
Checklist before requesting a review
nextaccording to naming convention.