Clippy

eth_test_parser/src/fs_scaffolding.rs

@@ -112,6 +112,7 @@ pub(crate) fn prepare_output_dir(out_path: &Path) -> Result<()> {
 
 /// Generate an iterator containing the deserialized test bodies (`TestBody`)
 /// and their `DirEntry`s.
+#[allow(clippy::type_complexity)]
 pub(crate) fn get_deserialized_test_bodies(
 ) -> Result<impl Iterator<Item = Result<(DirEntry, Vec<TestBody>), (String, String)>>> {
     Ok(get_test_files()?.map(|entry| {

evm_test_runner/src/persistent_run_state.rs

@@ -114,7 +114,7 @@ pub(crate) enum PassState {
 
 impl PassState {
     // Utility method to filter out passed tests from previous runs.
-    fn get_passed_status(&self, witness_only: bool) -> bool {
+    const fn get_passed_status(&self, witness_only: bool) -> bool {
         if witness_only {
             matches!(
                 self,

evm_test_runner/src/plonky2_runner.rs

@@ -94,7 +94,7 @@ impl Display for TestStatus {
 }
 
 impl TestStatus {
-    pub(crate) fn passed(&self) -> bool {
+    pub(crate) const fn passed(&self) -> bool {
         matches!(self, Self::PassedProof | Self::PassedWitness)
     }
 }

evm_test_runner/src/test_dir_reading.rs

@@ -157,14 +157,14 @@ async fn parse_test_sub_group(
 }
 
 fn blacklisted(blacklist: Option<&HashSet<String>>, t_name: &str) -> bool {
-    blacklist.map_or(false, |b_list| b_list.contains(t_name))
+    blacklist.is_some_and(|b_list| b_list.contains(t_name))
 }
 
 fn test_is_not_in_filter_str(filter_str: &Option<String>, file_path: &Path) -> bool {
     filter_str.as_ref().map_or(false, |f_str| {
         file_path
             .to_str()
-            .map_or(false, |p_str| !p_str.contains(f_str))
+            .is_some_and(|p_str| !p_str.contains(f_str))
     })
 }