-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Shanghai tests parsing #63
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9454343
Fix Shanghai tests parsing
Nashtare 0d3bb4b
Blacklist unprovable transactions that go beyong 2^32 CPU cycles
Nashtare 3c4fbea
Merge pull request #65 from topos-protocol/blacklist-unprovable
Nashtare 9549ce6
Apply suggestion
Nashtare b7c69b7
Add comment
Nashtare File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
pub const GENERATION_INPUTS_DEFAULT_OUTPUT_DIR: &str = "generation_inputs"; | ||
pub const MAIN_TEST_DIR: &str = "BlockchainTests"; | ||
pub const MAIN_TEST_DIR: &str = "Cancun/BlockchainTests"; | ||
pub const MATIC_CHAIN_ID: u64 = 137; | ||
pub const ETHEREUM_CHAIN_ID: u64 = 1; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,34 @@ | ||
pub(crate) const ETH_TESTS_REPO_URL: &str = "https://github.com/ethereum/tests.git"; | ||
use common::config::MAIN_TEST_DIR; | ||
|
||
// The PR <https://github.com/ethereum/tests/pull/1380> moved all test versions prior Cancun HF | ||
// to the `LegacyTests` folder instead. | ||
pub(crate) const ETH_TESTS_REPO_URL: &str = "https://github.com/ethereum/legacytests.git"; | ||
Nashtare marked this conversation as resolved.
Show resolved
Hide resolved
|
||
pub(crate) const ETH_TESTS_REPO_LOCAL_PATH: &str = "eth_tests"; | ||
pub(crate) const GENERAL_GROUP: &str = "BlockchainTests"; | ||
pub(crate) const GENERAL_GROUP: &str = MAIN_TEST_DIR; | ||
pub(crate) const TEST_GROUPS: [&str; 1] = ["GeneralStateTests"]; | ||
// The following subgroups contain subfolders unlike the other test folders. | ||
pub(crate) const SPECIAL_TEST_SUBGROUPS: [&str; 3] = ["Cancun", "Shanghai", "VMTests"]; | ||
pub(crate) const SPECIAL_TEST_SUBGROUPS: [&str; 2] = ["Shanghai", "VMTests"]; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There are actually no |
||
/// These test variants are used for stress testing. As such, they have | ||
/// unrealistic scenarios that go beyond the provable bounds of the zkEVM. | ||
/// Witness generation for these variants is still possible, but takes too | ||
/// much time to be useful and usable in testing occuring regularly. | ||
pub(crate) const UNPROVABLE_VARIANTS: [&str; 17] = [ | ||
"CALLBlake2f_d9g0v0_Shanghai", | ||
"CALLCODEBlake2f_d9g0v0_Shanghai", | ||
"Call50000_d0g1v0_Shanghai", | ||
"Callcode50000_d0g1v0_Shanghai", | ||
"static_Call50000_d1g0v0_Shanghai", | ||
"static_Call50000_ecrec_d0g0v0_Shanghai", | ||
"static_Call50000_ecrec_d1g0v0_Shanghai", | ||
"static_Call50000_identity2_d0g0v0_Shanghai", | ||
"static_Call50000_identity2_d1g0v0_Shanghai", | ||
"static_Call50000_identity_d0g0v0_Shanghai", | ||
"static_Call50000_identity_d1g0v0_Shanghai", | ||
"static_Call50000_rip160_d0g0v0_Shanghai", | ||
"static_Call50000_sha256_d0g0v0_Shanghai", | ||
"static_Call50000_sha256_d1g0v0_Shanghai", | ||
"static_Return50000_2_d0g0v0_Shanghai", | ||
"Return50000_d0g1v0_Shanghai", | ||
"Return50000_2_d0g1v0_Shanghai", | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name may be confusing, but it's implying all tests until Cancun included.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a comment to explain what
MAIN_TEST_DIR
corresponds to then?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it might be worth a comment just explaining that a sub-group is now the main sub-group, but I'm good either way.