This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Reach final decision on resolve_code_hash_fn #74
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGluth
reviewed
May 21, 2024
prover/src/lib.rs
Outdated
Comment on lines
44
to
45
| let txs = self.block_trace.into_txn_proof_gen_ir( | ||
| &ProcessingMeta::new(resolve_code_hash_fn), | ||
| other_data.clone(), | ||
| )?; | ||
| let txs = self | ||
| .block_trace | ||
| .into_proof_gen_mpt_ir(&resolve_code_hash_fn, other_data.clone())?; |
There was a problem hiding this comment.
I know this is still a draft, but I just want to give some extra info stemming from my comments in (230).
For now, I'm fine if we create an impl that has resolve as a todo!() or similar, just because currently all code mappings appear embedded in the pre-image and doing a proper impl of this is probably worth it's own PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - 0xPolygonZero/zk_evm#159
Dependent PR - 0xPolygonZero/zk_evm#230