Adding member_zrx_staked to epoch pool rewards query #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianny
reviewed
Mar 22, 2021
packages/api/package.json
Outdated
| "scripts": { | ||
| "build": "yarn tsc -b", | ||
| "clean": "rm -rf lib", | ||
| "dev": "nodemon -r dotenv/config src/index.ts | pino-pretty", |
xianny
approved these changes
Mar 22, 2021
|
I took a peek at 0xProject/website#366 for more context. Why not add Highly recommend doing aggregate queries and joins at the SQL layer instead of the API/network layer. Also, this data changes slowly so we can add a cache at the ingress layer for faster page loads. |
sui414
reviewed
Mar 22, 2021
packages/api/src/queries.ts
Outdated
| @@ -328,18 +328,21 @@ export const poolEpochRewardsQuery = ` | |||
| , e.ending_timestamp | |||
| , e.ending_block_number | |||
| , e.ending_transaction_hash | |||
| , esps.member_zrx_delegated AS member_zrx_staked | |||
There was a problem hiding this comment.
COALESCE(esps.member_zrx_delegated, 0.00)
sui414
approved these changes
Mar 31, 2021
Ktl-XV
pushed a commit
that referenced
this pull request
Apr 3, 2023
…ool-epoch-rewards Adding member_zrx_staked to epoch pool rewards query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to: 0xProject/website#366
Basically, we want to be able to see the amount of ZRX staked per each epoch. Currently, staking endpoint
staking/pools/{poolId}only shows amount of ZRX staked for current epoch and next epoch. Also added back nodemon dev npm script.