feat(mon-pix): leverage the new errorMessages service

1024pix · Jan 9, 2025 · 51eca4c · 51eca4c
1 parent 8ab49e6
commit 51eca4c
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 58 deletions.
diff --git a/mon-pix/app/components/authentication/login-or-register-oidc.js b/mon-pix/app/components/authentication/login-or-register-oidc.js
@@ -9,11 +9,7 @@ import isEmailValid from '../../utils/email-validator';
 
 const ERROR_INPUT_MESSAGE_MAP = {
   termsOfServiceNotSelected: 'pages.login-or-register-oidc.error.error-message',
-  unknownError: 'common.error',
-  expiredAuthenticationKey: 'pages.login-or-register-oidc.error.expired-authentication-key',
   invalidEmail: 'pages.login-or-register-oidc.error.invalid-email',
-  accountConflict: 'pages.login-or-register-oidc.error.account-conflict',
-  loginUnauthorizedError: 'pages.login-or-register-oidc.error.login-unauthorized-error',
 };
 
 export default class LoginOrRegisterOidcComponent extends Component {
@@ -23,6 +19,7 @@ export default class LoginOrRegisterOidcComponent extends Component {
   @service oidcIdentityProviders;
   @service store;
   @service url;
+  @service errorMessages;
 
   @tracked isTermsOfServiceValidated = false;
   @tracked loginErrorMessage = null;
@@ -70,15 +67,9 @@ export default class LoginOrRegisterOidcComponent extends Component {
 
     try {
       await this.args.onLogin({ enteredEmail: this.email, enteredPassword: this.password });
-    } catch (error) {
-      const status = get(error, 'errors[0].status');
-
-      const errorsMapping = {
-        401: this.intl.t(ERROR_INPUT_MESSAGE_MAP['expiredAuthenticationKey']),
-        404: this.intl.t(ERROR_INPUT_MESSAGE_MAP['loginUnauthorizedError']),
-        409: this.intl.t(ERROR_INPUT_MESSAGE_MAP['accountConflict']),
-      };
-      this.loginErrorMessage = errorsMapping[status] || this.intl.t(ERROR_INPUT_MESSAGE_MAP['unknownError']);
+    } catch (responseError) {
+      const error = get(responseError, 'errors[0]');
+      this.loginErrorMessage = this.errorMessages.getErrorMessage(error);
     } finally {
       this.isLoginLoading = false;
     }
@@ -102,24 +93,7 @@ export default class LoginOrRegisterOidcComponent extends Component {
       });
     } catch (responseError) {
       const error = get(responseError, 'errors[0]');
-      switch (error?.code) {
-        case 'INVALID_LOCALE_FORMAT':
-          this.registerErrorMessage = this.intl.t('pages.sign-up.errors.invalid-locale-format', {
-            invalidLocale: error.meta.locale,
-          });
-          return;
-        case 'LOCALE_NOT_SUPPORTED':
-          this.registerErrorMessage = this.intl.t('pages.sign-up.errors.locale-not-supported', {
-            localeNotSupported: error.meta.locale,
-          });
-          return;
-      }
-      if (error.status === '401') {
-        this.registerErrorMessage = this.intl.t(ERROR_INPUT_MESSAGE_MAP['expiredAuthenticationKey']);
-      } else {
-        this.registerErrorMessage =
-          this.intl.t(ERROR_INPUT_MESSAGE_MAP['unknownError']) + (error.detail ? ` (${error.detail})` : '');
-      }
+      this.registerErrorMessage = this.errorMessages.getErrorMessage(error);
     } finally {
       this.isRegisterLoading = false;
     }

diff --git a/mon-pix/app/components/authentication/oidc-reconciliation.js b/mon-pix/app/components/authentication/oidc-reconciliation.js
@@ -2,12 +2,12 @@ import { action } from '@ember/object';
 import { service } from '@ember/service';
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
-import get from 'lodash/get';
 
 export default class OidcReconciliationComponent extends Component {
   @service intl;
   @service oidcIdentityProviders;
   @service session;
+  @service errorMessages;
 
   @tracked reconcileErrorMessage = null;
   @tracked isLoading = false;
@@ -49,12 +49,8 @@ export default class OidcReconciliationComponent extends Component {
         identityProviderSlug: this.args.identityProviderSlug,
         hostSlug: 'user/reconcile',
       });
-    } catch (error) {
-      const status = get(error, 'errors[0].status');
-      const errorsMapping = {
-        401: this.intl.t('pages.login-or-register-oidc.error.expired-authentication-key'),
-      };
-      this.reconcileErrorMessage = errorsMapping[status] || this.intl.t('common.error');
+    } catch (responseError) {
+      this.reconcileErrorMessage = this.errorMessages.getErrorMessage(responseError);
     } finally {
       this.isLoading = false;
     }

diff --git a/mon-pix/tests/unit/components/authentication/login-or-register-oidc-test.js b/mon-pix/tests/unit/components/authentication/login-or-register-oidc-test.js
@@ -43,7 +43,7 @@ module('Unit | Component | authentication | login-or-register-oidc', function (h
           const component = createGlimmerComponent('authentication/login-or-register-oidc');
 
           const sessionService = stubSessionService(this.owner, { isAuthenticated: false });
-          sessionService.authenticate.rejects({ errors: [{ status: '401' }] });
+          sessionService.authenticate.rejects({ errors: [{ status: '401', code: 'EXPIRED_AUTHENTICATION_KEY' }] });
 
           component.args.identityProviderSlug = 'super-idp';
           component.args.authenticationKey = 'super-key';
@@ -126,23 +126,6 @@ module('Unit | Component | authentication | login-or-register-oidc', function (h
         });
       });
 
-      test('displays an error message with details', async function (assert) {
-        // given
-        const component = createGlimmerComponent('authentication/login-or-register-oidc');
-        const sessionService = stubSessionService(this.owner, { isAuthenticated: false });
-        sessionService.authenticate.rejects({ errors: [{ status: '500', detail: 'some detail' }] });
-
-        component.args.identityProviderSlug = 'super-idp';
-        component.args.authenticationKey = 'super-key';
-        component.isTermsOfServiceValidated = true;
-
-        // when
-        await component.register();
-
-        // then
-        assert.strictEqual(component.registerErrorMessage, `${t('common.error')} (some detail)`);
-      });
-
       test('displays a default error message', async function (assert) {
         // given
         const component = createGlimmerComponent('authentication/login-or-register-oidc');
@@ -277,7 +260,9 @@ module('Unit | Component | authentication | login-or-register-oidc', function (h
         test('should display error', async function (assert) {
           // given
           const component = createGlimmerComponent('authentication/login-or-register-oidc');
-          component.args.onLogin = sinon.stub().rejects({ errors: [{ status: '401' }] });
+          component.args.onLogin = sinon
+            .stub()
+            .rejects({ errors: [{ status: '401', code: 'EXPIRED_AUTHENTICATION_KEY' }] });
           component.email = '[email protected]';
           component.password = 'pix123';
           const eventStub = { preventDefault: sinon.stub() };

diff --git a/mon-pix/tests/unit/components/authentication/oidc-reconciliation-test.js b/mon-pix/tests/unit/components/authentication/oidc-reconciliation-test.js
@@ -169,7 +169,7 @@ module('Unit | Component | authentication | oidc-reconciliation', function (hook
           // given
           const component = createGlimmerComponent('authentication/oidc-reconciliation');
           const sessionService = stubSessionService(this.owner, { isAuthenticated: false });
-          sessionService.authenticate.rejects({ errors: [{ status: '401' }] });
+          sessionService.authenticate.rejects({ errors: [{ status: '401', code: 'EXPIRED_AUTHENTICATION_KEY' }] });
 
           component.args.identityProviderSlug = 'super-idp';
           component.args.authenticationKey = 'super-key';