[FEATURE] Prendre en compte flashcards dans les scripts CSV (PIX-15634)(PIX-15857) #10897
+261
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
dianeCdrPix
changed the title
dianeCdrPix
changed the title
dianeCdrPix
force-pushed
the
pix-15857-add-flashcards-in-csv-extract
branch
from
c9f9464 to
011e860
Compare
yannbertrand
force-pushed
the
pix-15857-add-flashcards-in-csv-extract
branch
from
10c4cc0 to
a1118a4
Compare
clemlatz
force-pushed
the
pix-15857-add-flashcards-in-csv-extract
branch
2 times, most recently
from
63b856f to
ea54a3d
Compare
dianeCdrPix
force-pushed
the
pix-15857-add-flashcards-in-csv-extract
branch
from
ea54a3d to
96c6c98
Compare
Co-authored-by: Clément Latzarus <[email protected]> Co-authored-by: Diane Cordier <[email protected]> Co-authored-by: Eric Lim <[email protected]>
dianeCdrPix
force-pushed
the
pix-15857-add-flashcards-in-csv-extract
branch
from
96c6c98 to
349540f
Compare
yannbertrand
reviewed
Jan 9, 2025
Comment on lines
+43
to
+44
| "type": "activity", | ||
| "title": "Voici un grain d'activité", |
There was a problem hiding this comment.
je ne sais plus si c'est un oubli
clemlatz
approved these changes
Jan 9, 2025
| @@ -3,6 +3,28 @@ import { fileURLToPath } from 'node:url'; | |||
| import moduleDatasource from '../../src/devcomp/infrastructure/datasources/learning-content/module-datasource.js'; | |||
| import { getCsvContent } from '../../src/shared/infrastructure/utils/csv/write-csv-utils.js'; | |||
|
|
|||
| export function _getTotalElementsCount(grains) { | |||
There was a problem hiding this comment.
suggestion: mettre la méthode pseudo-privée à la fin du fichier pour commencer par le plus important.
| import { catchErrSync, expect } from '../../../test-helper.js'; | ||
|
|
||
| describe('Unit | Scripts | Get Modules as CSV', function () { | ||
| describe('#getTotalElements', function () { |
There was a problem hiding this comment.
Suggested change
| describe('#getTotalElements', function () { | |
| describe('#_getTotalElementsCount', function () { |
Par ailleurs je trouve toujours bizarre de tester unitairement une méthode privée… mais je n'ai pas mieux à proposer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎄 Problème
Les scripts
get-elements-csv.js,get-modules-csv.jspermettent d’extraire le référentiel de Modulix pour faire des stats.Il faut ajouter l'élement Flashcards dans ce qui peut être extrait.
🎁 Proposition
Ajouter flashcards dans les éléments extractables.
🧦 Remarques
Pour
get-proposals-csv, on rééchangera avec le métier pour comprendre les besoins.🎅 Pour tester
Utiliser les scripts
get-modules-csvetget-elements-csvet s'assurer que les flashcards sont bien comptabilisées