Fix typos #839
Fix typos #839
Conversation
|
|
||
| [default] | ||
| extend-ignore-re = [ | ||
| "\\bTung Du\\b", |
There was a problem hiding this comment.
Not variable_names go here.
| "\\bTung Du\\b", | ||
| ] | ||
|
|
||
| [default.extend-words] |
There was a problem hiding this comment.
These are parts of variable names.
| # Typos | ||
| "weather" = "whether" | ||
|
|
||
| [default.extend-identifiers] |
There was a problem hiding this comment.
Complete variable names.
| "Wordpress" = "WordPress" | ||
| "Woocommerce" = "WooCommerce" | ||
| "get_post_stati" = "get_post_stati" | ||
| "Automattic" = "Automattic" |
There was a problem hiding this comment.
This means: DO NOT CORRECT
jeffpaul
requested review from
iamdharmesh
and removed request for
a team,
dkotter and
jeffpaul
| @@ -458,7 +458,7 @@ public function render_meta_box( \WP_Post $post ) { | |||
| </label> | |||
| </p> | |||
|
|
|||
| <div class="classifai-clasify-post-wrapper" style="display: none;"> | |||
| <div class="classifai-classify-post-wrapper" style="display: none;"> | |||
There was a problem hiding this comment.
While this is a typo, because this is used as a class name, we'll need to decide if we want to leave this as-is, as others may be relying on this class for styling purposes and updating this will break things for them. Not overly concerned but something for us to consider
| @@ -870,7 +870,7 @@ input.classifai-button { | |||
| } | |||
|
|
|||
| // Start: Classify Post Modal | |||
| .classify-post-componenet { | |||
| .classify-post-component { | |||
There was a problem hiding this comment.
In doing a quick search to see if the classify-post-componenet class was used elsewhere (and thus may need updated) it doesn't appear so. Seems all other places use the proper class name. What this means though is this style has not been applying so we'll need to do some QA here to ensure this style doesn't cause any problems
| @@ -513,7 +513,7 @@ document.addEventListener( 'DOMContentLoaded', function () { | |||
| if ( classifaiNLUCheckbox ) { | |||
| classifaiNLUCheckbox.addEventListener( 'change', function () { | |||
| const classifyButton = document.querySelector( | |||
| '.classifai-clasify-post-wrapper' | |||
| '.classifai-classify-post-wrapper' | |||
There was a problem hiding this comment.
If we decide we don't want to change this class name (mentioned in another comment) we'll want to revert this change as well
| @@ -158,7 +158,7 @@ const TaxonomyControls = ( { onChange, query } ) => { | |||
| // Append newTerm to taxoInfo.terms. | |||
| const terms = { | |||
| ...taxoInfo.terms, | |||
| entitites: [ | |||
| entities: [ | |||
There was a problem hiding this comment.
It seems like this typo may have caused problems but would be curious to know if that was the case
There was a problem hiding this comment.
typos is a very useful tool. Not every day but the benefits are great on those days.
There was a problem hiding this comment.
BTW tsc from Typescript does perform static analysis on JavaScript too.
Description of the Change
Introduce https://github.com/crate-ci/typos to ClassifAI.