Blog permalink #55
Merged
Blog permalink #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-ack
approved these changes
Dec 26, 2024
12Me21
reviewed
Dec 26, 2024
src/Views/page.js
Outdated
| if (!OPTS.has('dev')) { | ||
| const domain = Req.server.split("/")[0] | ||
| let href = undefined | ||
| if (Object.hasOwn(page.values, "share") && page.values.share) { |
There was a problem hiding this comment.
why are we checking page.values.share twice? (i would just use if (page.values.share))
There was a problem hiding this comment.
it's to check if it's also a truthy value. if page.values.share won't throw an exception then i can also do that
There was a problem hiding this comment.
ok yes i can do that, pushing a change
12Me21
reviewed
Dec 26, 2024
src/navigate.js
Outdated
| @@ -66,6 +66,7 @@ class ViewSlot { | |||
| for (let x of items) { | |||
| let a = document.createElement('a') | |||
| a.href = x.href | |||
| a.target = x['target'] ?? '_self' | |||
There was a problem hiding this comment.
- should just be x.target || '_self' (i don't use ?? anywhere else in the code (..i hope i had a good reason for this))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #37