Stubbing out a location schema example #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and a sample extended badge class that uses it
…a and its example
|
Just in case you weren't aware, json-schema has some standardized schemas that cover things like locations and events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this in for discussion.
Thought it'd be a good idea to include the ability to have an online location and multiple addresses. Can't think of a use case where multiple online locations would be needed.
Wondering - is this schema defined properly? Also, it gets tricky to define values for state_province and country. Use abbreviations, country codes instead? Added geolocation which in itself isn't super useful unless it's being plugged into a mapping system. In which case, displayers could use libraries to translate the physical address to coordinates.