Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

550 misuse of language in examples and i18n documentation #558

Merged

Conversation

xaviaracil
Copy link
Collaborator

Proposal to solve issue #550 using the action number 2:

Add a new property inLanguage to the context, such as with the https://schema.org/inLanguage IRI and update relevant > classes, schema, and examples in implementation guide to use that property. This completely solves the problem with very > little "splash damage". But it doesn't take advantage of any JSON-LD special features for string labeling.

Rendered versions of the documents can be found at:

@xaviaracil xaviaracil linked an issue Dec 13, 2023 that may be closed by this pull request
ob_v2p0/index.md Outdated
<html>
<head><title>Hello</title></head>
<body><p>Hello</p></body>
</html>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of replacing the OB 2.0 document with "Hello"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks like a bunch of other things are included in this PR maybe accidentally. I'm not sure what these large structural changes in the repo are about or if they're intentional. Could those be separated out into another PR so that this could be rebased to target just the changes about language?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified to include only changes related to this issue

@xaviaracil xaviaracil force-pushed the 550-misuse-of-language-in-examples-and-i18n-documentation branch from e0ad3db to 950414f Compare January 24, 2024 10:59
@xaviaracil xaviaracil merged commit e258a08 into develop Jan 26, 2024
3 checks passed
@xaviaracil xaviaracil deleted the 550-misuse-of-language-in-examples-and-i18n-documentation branch January 26, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misuse of @language in examples and i18n documentation
2 participants