Представление и описание #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… на основании синонима. Поддерживается для всех MD\MDClass
WalkthroughThe recent updates involve the addition of a new Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Test Results 53 files ±0 53 suites ±0 31s ⏱️ +17s Results for commit a5311a3. ± Comparison against base commit 70f005e. This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to path filters (65)
src/test/resources/fixtures/mdclasses/AccountingRegisters.РегистрБухгалтерии1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/AccumulationRegisters.РегистрНакопления1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/BusinessProcesses.БизнесПроцесс1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/BusinessProcesses.БизнесПроцесс1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/CalculationRegisters.РегистрРасчета1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/CalculationRegisters.РегистрРасчета1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Catalogs.Справочник1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Catalogs.Справочник1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ChartsOfAccounts.ПланСчетов1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ChartsOfAccounts.ПланСчетов1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ChartsOfCalculationTypes.ПланВидовРасчета1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ChartsOfCharacteristicTypes.ПланВидовХарактеристик1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ChartsOfCharacteristicTypes.ПланВидовХарактеристик1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Configuration.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Configuration_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Constants.Константа1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Constants.Константа1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/DataProcessors.Обработка1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/DataProcessors.Обработка1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/DocumentJournals.ЖурналДокументов1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/DocumentJournals.ЖурналДокументов1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Documents.Документ1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Documents.Документ1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Enums.Перечисление1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Enums.Перечисление1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ExchangePlans.ПланОбмена1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ExchangePlans.ПланОбмена1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ExternalDataSources.ТекущаяСУБД.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/ExternalDataSources.ТекущаяСУБД_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/FilterCriteria.КритерийОтбора1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/FilterCriteria.КритерийОтбора1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/InformationRegisters.РегистрСведений1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/InformationRegisters.РегистрСведений1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Reports.Отчет1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Reports.Отчет1_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses/Tasks.Задача1.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses_3_18/Configuration.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses_3_18/Configuration_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses_ext/Configuration.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/mdclasses_ext/Configuration_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/BusinessProcesses.Задание.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/BusinessProcesses.Задание_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Catalogs.Заметки.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Catalogs.Заметки_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/ChartsOfCharacteristicTypes.ДополнительныеРеквизитыИСведения_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Constants.ЗаголовокСистемы.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/DataProcessors.ЗагрузкаКурсовВалют.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/DataProcessors.ЗагрузкаКурсовВалют_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/DocumentJournals.Взаимодействия.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/DocumentJournals.Взаимодействия_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Documents.Анкета.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Documents.Анкета_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Enums.СтатусыОбработчиковОбновления.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Enums.СтатусыОбработчиковОбновления_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/ExchangePlans.ОбновлениеИнформационнойБазы.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/ExchangePlans.ОбновлениеИнформационнойБазы_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/FilterCriteria.ФайлыВТоме.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/FilterCriteria.ФайлыВТоме_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/InformationRegisters.ЭлектронныеПодписи.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/InformationRegisters.ЭлектронныеПодписи_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Reports.АнализВерсийОбъектов.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Reports.АнализВерсийОбъектов_edt.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Tasks.ЗадачаИсполнителя.jsonis excluded by:!**/*.jsonsrc/test/resources/fixtures/ssl_3_1/Tasks.ЗадачаИсполнителя_edt.jsonis excluded by:!**/*.json
Files selected for processing (26)
- src/main/java/com/github/_1c_syntax/bsl/mdo/AccountingRegister.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/AccumulationRegister.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/BusinessProcess.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/CalculationRegister.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/Catalog.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfAccounts.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCalculationTypes.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCharacteristicTypes.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/Constant.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/DataProcessor.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/Document.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/DocumentJournal.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/Enum.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/ExchangePlan.java (2 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/ExternalDataSource.java (2 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/FilterCriterion.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/InformationRegister.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/MD.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/Report.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/Subsystem.java (3 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/Task.java (1 hunks)
- src/main/java/com/github/_1c_syntax/bsl/mdo/support/MultiLanguageString.java (1 hunks)
- src/test/java/com/github/_1c_syntax/bsl/mdclasses/ConfigurationTest.java (3 hunks)
- src/test/java/com/github/_1c_syntax/bsl/mdo/AccountingRegisterTest.java (1 hunks)
- src/test/java/com/github/_1c_syntax/bsl/mdo/BusinessProcessTest.java (1 hunks)
- src/test/java/com/github/_1c_syntax/bsl/mdo/CatalogTest.java (2 hunks)
Files skipped from review due to trivial changes (3)
- src/main/java/com/github/_1c_syntax/bsl/mdo/AccumulationRegister.java
- src/main/java/com/github/_1c_syntax/bsl/mdo/ExchangePlan.java
- src/main/java/com/github/_1c_syntax/bsl/mdo/ExternalDataSource.java
Additional comments: 24
src/main/java/com/github/_1c_syntax/bsl/mdo/Constant.java (1)
- 79-84: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYis consistent with the PR's objectives to enhance metadata object descriptions with localized support. This change aligns with the internationalization efforts described.src/test/java/com/github/_1c_syntax/bsl/mdo/AccountingRegisterTest.java (1)
- 44-52: The added assertions for the
synonymanddescriptionproperties in theAccountingRegisterTestclass are appropriate for verifying the behavior of theAccountingRegisterclass with respect to the newexplanationfield and thegetDescriptionmethods. This ensures that the new functionality is covered by tests.src/main/java/com/github/_1c_syntax/bsl/mdo/FilterCriterion.java (1)
- 90-94: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theFilterCriterionclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/Catalog.java (1)
- 88-92: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theCatalogclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/BusinessProcess.java (1)
- 87-91: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theBusinessProcessclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCalculationTypes.java (1)
- 88-92: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theChartOfCalculationTypesclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfCharacteristicTypes.java (1)
- 88-92: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theChartOfCharacteristicTypesclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/AccountingRegister.java (1)
- 91-95: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theAccountingRegisterclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/InformationRegister.java (1)
- 91-95: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theInformationRegisterclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/Document.java (1)
- 94-98: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theDocumentclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/Report.java (1)
- 114-118: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theReportclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/MD.java (1)
- 78-106: The addition of the
getDescription()andgetDescription(String code)default methods to theMDinterface is a significant enhancement. These methods provide a standardized way to retrieve object representations based on synonyms, with a fallback to the object's name if no synonyms are available. This change supports the internationalization capabilities described in the PR objectives.src/main/java/com/github/_1c_syntax/bsl/mdo/DataProcessor.java (1)
- 114-118: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theDataProcessorclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/Task.java (1)
- 97-101: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theTaskclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/CalculationRegister.java (1)
- 96-100: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theCalculationRegisterclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/Enum.java (1)
- 107-111: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theEnumclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/DocumentJournal.java (1)
- 114-118: The addition of the
explanationfield with a default value ofMultiLanguageString.EMPTYto theDocumentJournalclass is consistent with the PR's objectives and follows the pattern established for other metadata objects.src/main/java/com/github/_1c_syntax/bsl/mdo/ChartOfAccounts.java (1)
- 104-108: The
explanationfield is initialized withMultiLanguageString.EMPTY. This is consistent with the pattern used for other default fields in the class. However, ensure that thegetAllAttributes()method, which aggregates attributes, is not affected by the addition of this new field, as it does not seem to be included in the list of attributes returned by the method.src/test/java/com/github/_1c_syntax/bsl/mdo/BusinessProcessTest.java (2)
- 44-51: The assertions in the
testmethod check for the emptiness of synonyms and descriptions in different languages. This is consistent with the expected behavior of theBusinessProcessobject when no synonyms or descriptions are set.- 66-75: The assertions in the
testSSL_3_1method check for the presence of synonyms and descriptions in different languages. The method name suggests that it is testing specific behavior related to SSL version 3.1, which should be documented for clarity.src/main/java/com/github/_1c_syntax/bsl/mdo/Subsystem.java (1)
- 109-113: The
explanationfield is correctly annotated with@Defaultand initialized withMultiLanguageString.EMPTY. This change is consistent with the pattern used for other default fields in the class.src/test/java/com/github/_1c_syntax/bsl/mdo/CatalogTest.java (1)
- 116-130: The assertions in the
testSSLmethod check for the presence of synonyms and descriptions in different languages for both theCatalogobject and its child attribute. This is consistent with the expected behavior of theCatalogobject when synonyms and descriptions are set.src/test/java/com/github/_1c_syntax/bsl/mdclasses/ConfigurationTest.java (2)
- 171-175: The assertions in the
testFullSSLmethod check for the presence of synonyms and descriptions in different languages. The method name suggests that it is testing specific behavior related to SSL, which should be documented for clarity. Additionally, the method now throws anException, which is not documented in the method signature comment.- 407-407: The
checkChildrenMdclassesmethod is private and static, which is appropriate for utility methods used within tests. It checks various properties of theConfigurationobject, ensuring that they match expected values based on theSupportVariant.
src/main/java/com/github/_1c_syntax/bsl/mdo/support/MultiLanguageString.java
Show resolved
Hide resolved
src/main/java/com/github/_1c_syntax/bsl/mdo/support/MultiLanguageString.java
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Связанные задачи
Closes
Чеклист
Общие
gradlew precommit)Дополнительно
Summary by CodeRabbit
New Features
Enhancements
Tests