Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subsystemFilter #334

Merged
merged 3 commits into from
Jul 12, 2024
Merged

subsystemFilter #334

merged 3 commits into from
Jul 12, 2024
+42 −1

Conversation

asosnoviy
Copy link
Member

@asosnoviy asosnoviy commented Jul 2, 2024 •
edited
Loading

Фильтр по подсистемам добавлен в настройки
fix #319

image

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 2, 2024 •
edited
Loading

Walkthrough

Эти изменения добавляют новые конфигурационные опции для фильтрации подсистем в настройках проекта Sonar. Включены новые строки для ключей включения и исключения фильтров подсистем в классе BSLCommunityProperties, а также новые описания и имена фильтров в ресурсных файлах. Исправлен тест для учета новых расширений, и обновлены документации с новыми параметрами конфигурации.

Changes

Файлы Сводка изменений
src/main/java/com/github/.../BSLCommunityProperties.java Добавлены новые публичные статические строки для включения и исключения фильтров подсистем, обновлен метод getProperties.
src/main/java/com/github/.../BSLCoreSensor.java Изменения для включения и исключения фильтров подсистем в объекте configuration.
src/main/resources/org/sonar/l10n/communitybsl.properties Добавлены описания и имена для фильтров подсистем.
src/main/resources/org/sonar/l10n/communitybsl_ru.properties Добавлены описания и имена для фильтров подсистем на русском языке.
src/test/java/com/github/.../BSLPluginTest.java Изменение в методе testGetExtensions для учета новых расширений.
docs/en/index.md Добавлены параметры конфигурации для фильтрации подсистем в настройках BSL Language Server.
docs/index.md Добавлены настройки конфигурации для фильтров включения и исключения подсистем, с указанием значений по умолчанию: пустая строка.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant SonarQube
    participant BSLCommunityProperties
    participant BSLCoreSensor

    User->>SonarQube: Update Configuration
    SonarQube->>BSLCommunityProperties: Fetch Properties
    BSLCommunityProperties->>BSLCoreSensor: Update Configuration with Filters
    BSLCoreSensor->>SonarQube: Apply Filters
    SonarQube->>User: Configuration Updated
Loading

Assessment against linked issues

Objective Addressed Explanation
Добавить возможность указывать фильтр подсистем в настройках проекта Sonar (#319) ✅

Poem

В коде строки добавились,
Фильтры в сонар внедрились,
Включаем и исключаем,
Подсистемы мы решаем.
Тесты все учли заботливо,
Документацию обновили ловко.
🎉🐇

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@asosnoviy asosnoviy force-pushed the feature/subsistemFilter branch from b2397ce to 7bf3bd3 Compare July 2, 2024 19:45
@asosnoviy asosnoviy marked this pull request as draft July 2, 2024 19:48
coderabbitai[bot]
coderabbitai bot reviewed Jul 2, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between bdfce33 and 7bf3bd3.

Files selected for processing (5)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCommunityProperties.java (2 hunks)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCoreSensor.java (1 hunks)
  • src/main/resources/org/sonar/l10n/communitybsl.properties (1 hunks)
  • src/main/resources/org/sonar/l10n/communitybsl_ru.properties (1 hunks)
  • src/test/java/com/github/_1c_syntax/bsl/sonar/BSLPluginTest.java (1 hunks)
Files skipped from review due to trivial changes (1)
  • src/main/resources/org/sonar/l10n/communitybsl.properties
Additional comments not posted (5)
src/main/resources/org/sonar/l10n/communitybsl_ru.properties (1)

13-16: Проверьте правильность и соответствие добавленных строк.

Добавленные строки для описания и имен фильтров подсистем выглядят корректно, но стоит убедиться, что они соответствуют существующему стилю и формату.

src/test/java/com/github/_1c_syntax/bsl/sonar/BSLPluginTest.java (1)

53-53: Обновите количество расширений в тесте.

Изменение количества расширений с 23 до 25 выглядит корректным, учитывая добавление новых свойств фильтров подсистем.

src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCommunityProperties.java (2)

44-45: Добавлены новые ключи фильтров подсистем.

Новые константы для ключей фильтров подсистем добавлены корректно.

101-113: Добавлены новые свойства фильтров подсистем.

Новые свойства фильтров подсистем добавлены корректно и соответствуют существующему формату.

src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCoreSensor.java (1)

331-343: Добавлена настройка фильтров подсистем в конфигурации.

Код для настройки включения и исключения фильтров подсистем выглядит корректным и соответствует существующему стилю.

@asosnoviy asosnoviy force-pushed the feature/subsistemFilter branch from 7bf3bd3 to 022c59b Compare July 3, 2024 06:42
@asosnoviy asosnoviy marked this pull request as ready for review July 3, 2024 10:00
coderabbitai[bot]
coderabbitai bot reviewed Jul 3, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 7bf3bd3 and 022c59b.

Files selected for processing (5)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCommunityProperties.java (2 hunks)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCoreSensor.java (1 hunks)
  • src/main/resources/org/sonar/l10n/communitybsl.properties (1 hunks)
  • src/main/resources/org/sonar/l10n/communitybsl_ru.properties (1 hunks)
  • src/test/java/com/github/_1c_syntax/bsl/sonar/BSLPluginTest.java (1 hunks)
Files skipped from review as they are similar to previous changes (5)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCommunityProperties.java
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCoreSensor.java
  • src/main/resources/org/sonar/l10n/communitybsl.properties
  • src/main/resources/org/sonar/l10n/communitybsl_ru.properties
  • src/test/java/com/github/_1c_syntax/bsl/sonar/BSLPluginTest.java

@asosnoviy asosnoviy force-pushed the feature/subsistemFilter branch from 022c59b to 1972319 Compare July 11, 2024 09:29
coderabbitai[bot]
coderabbitai bot reviewed Jul 11, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 022c59b and 1972319.

Files selected for processing (5)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCommunityProperties.java (2 hunks)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCoreSensor.java (1 hunks)
  • src/main/resources/org/sonar/l10n/communitybsl.properties (1 hunks)
  • src/main/resources/org/sonar/l10n/communitybsl_ru.properties (1 hunks)
  • src/test/java/com/github/_1c_syntax/bsl/sonar/BSLPluginTest.java (1 hunks)
Files skipped from review due to trivial changes (2)
  • src/main/resources/org/sonar/l10n/communitybsl.properties
  • src/test/java/com/github/_1c_syntax/bsl/sonar/BSLPluginTest.java
Additional comments not posted (4)
src/main/resources/org/sonar/l10n/communitybsl_ru.properties (1)

13-16: Проверьте точность и согласованность переводов.

Убедитесь, что переводы новых строк "Список подсистем для замечаний" и "Исключая подсистемы" согласованы с остальными строками в файле.

src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCommunityProperties.java (2)

44-45: Добавлены новые статические константы.

Новые ключи для фильтрации подсистем добавлены корректно.

101-113: Проверьте корректность добавленных настроек.

Новые настройки для фильтрации подсистем добавлены в метод getProperties().

src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCoreSensor.java (1)

331-343: Проверьте корректность добавленных фильтров подсистем.

Изменения в методе getLanguageServerConfiguration для включения фильтров подсистем выглядят корректно.

coderabbitai[bot]
coderabbitai bot reviewed Jul 11, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 1972319 and 418e11f.

Files selected for processing (2)
  • docs/en/index.md (1 hunks)
  • docs/index.md (1 hunks)
Additional comments not posted (2)
docs/en/index.md (1)

92-93: Добавлено описание новых настроек для фильтров подсистем

Настройки описаны корректно и последовательно. Хорошо, что добавлены значения по умолчанию и подробное описание.

docs/index.md (1)

94-95: Добавлено описание новых настроек для фильтров подсистем

Настройки описаны корректно и последовательно. Хорошо, что добавлены значения по умолчанию и подробное описание.

@theshadowco
Update BSLCommunityProperties.java
bc45d80 
поменял порядок параметров
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

coderabbitai[bot]
coderabbitai bot reviewed Jul 12, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 418e11f and bc45d80.

Files selected for processing (1)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCommunityProperties.java (2 hunks)
Files skipped from review as they are similar to previous changes (1)
  • src/main/java/com/github/_1c_syntax/bsl/sonar/BSLCommunityProperties.java

@theshadowco theshadowco merged commit fc4eb1c into develop Jul 12, 2024
14 checks passed
@theshadowco theshadowco deleted the feature/subsistemFilter branch July 12, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@theshadowco theshadowco theshadowco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@asosnoviy @theshadowco