SAPHY-140 refactor: 결제 기능 리펙토링 #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: Pay 엔티티 필드 수정 * feat: 결제 준비, 결제 완료 DTO 생성
gyuseon25
approved these changes
Oct 2, 2024
gyuseon25
approved these changes
Oct 2, 2024
|
|
||
| // 물품 금액과 결제 금액이 같은지 검증 | ||
| if (!iamportPayment.getAmount().equals(item.getPrice())) { | ||
| BigDecimal calculatedAmount = item.getPrice().multiply(BigDecimal.valueOf(request.getQuantity())); |
There was a problem hiding this comment.
오 BigDecimal이라 직접 안곱하고 multiply를 쓰는거군요
하나 배워갑니다 👏
holyPigeon
approved these changes
Oct 2, 2024
| @@ -34,56 +37,54 @@ public class PayService { | |||
| private final IamportClient iamportClient; | |||
There was a problem hiding this comment.
여기서 ItemRepository -> ItemRepository<Item> 으로 바꾸면 밑에 로직에서 Optional을 안 써도 될 것 같습니다!
Comment on lines
+47
to
+49
| if (item.getStock() < request.getQuantity()) { | ||
| throw SaphyException.from(ITEM_OUT_OF_STOCK); | ||
| } |
There was a problem hiding this comment.
어 이거 제가 1시간 전에 PR 올린 거에 들어있는 거긴 한데
item 엔티티 안에 재고에 따라 주문할 수 있는지 없는지 boolean canOrder() 메서드로 구현해놔서 나중에 바꿔도 될 것 같습니다!
| try { | ||
| // PortOne 결제 확인 | ||
| iamportResponse = iamportClient.paymentByImpUid(request.getImpUid()); | ||
| if (payResponse.getResponse().getAmount().equals(pay.getAmount())) { |
There was a problem hiding this comment.
여기 if문 조건은 뭔가 private 메서드로 뽑을 수 있으면 훨씬 깔끔할 것 같습니다!
MinSang22Kim
approved these changes
Oct 2, 2024
| .orElseThrow(() -> SaphyException.from(PAY_NOT_FOUND)); | ||
| return new PayResponse(pay.getId(), pay.getTransactionId(), pay.getStatus()); | ||
| private String generateMerchantUid() { | ||
| return "ORD-" + UUID.randomUUID(); |
There was a problem hiding this comment.
UUID 앞에 ORD를 붙여서 직관적이라 좋은 거 같아요! 예전에 재우님 코드 리뷰에 있었던 내용을 반영한 건가요~?
Comment on lines
+47
to
54
| if (item.getStock() < request.getQuantity()) { | ||
| throw SaphyException.from(ITEM_OUT_OF_STOCK); | ||
| } | ||
|
|
||
| // 물품 금액과 결제 금액이 같은지 검증 | ||
| if (!iamportPayment.getAmount().equals(item.getPrice())) { | ||
| BigDecimal calculatedAmount = item.getPrice().multiply(BigDecimal.valueOf(request.getQuantity())); | ||
| if (!calculatedAmount.equals(request.getAmount())) { | ||
| throw SaphyException.from(PAY_PRICE_MISMATCH); | ||
| } |
There was a problem hiding this comment.
나중에 이런 조건문들은 private 메서드로 따로 빼서 리팩토링 하면 더 코드가 깔끔해질 거 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🕰️ Actual Time of Completion
🙋🏻 More