remove global_params #452
Draft
remove global_params #452
+56
−78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4-prep #452 +/- ##
========================================
Coverage 79.54% 79.54%
========================================
Files 24 24
Lines 3804 3804
Branches 647 647
========================================
Hits 3026 3026
Misses 559 559
Partials 219 219 ☔ View full report in Codecov by Sentry. |
|
|
||
| .HII_FILTER = 0, //IonisationBox, filter for reion ES (move to AstroParams) |
There was a problem hiding this comment.
I think anything that is not a continuous parameter should be in flag options, not astro params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm setting up a draft PR for removing the global parameter structure, as many of these are under/unused.
For now I've removed the parameters which were completely unused and I've commented on the others with suggestions of what to do with them.
I will begin to go through the parameters and move/delete them as necessary.