Skip to content

Commit

Permalink
Fixed recently introduced bug that caused clusters with last operatio…
Browse files Browse the repository at this point in the history
…n type Create and state Succeeded not to show the succeeded icon (gardener#2049)

Co-authored-by: Holger Koser <[email protected]>
  • Loading branch information
grolu and holgerkoser authored Sep 3, 2024
1 parent 06a89a6 commit 774abe9
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions frontend/src/components/GShootStatus.vue
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ SPDX-License-Identifier: Apache-2.0
v-bind="mergeProps(activatorProps, tooltipProps)"
density="comfortable"
variant="text"
:icon="true"
icon
>
<v-progress-circular
v-if="showProgress"
Expand All @@ -41,7 +41,7 @@ SPDX-License-Identifier: Apache-2.0
:color="color"
>
<v-icon
v-if="!!statusIcon"
v-if="hasStatusIcon"
size="small"
:color="color"
:icon="statusIcon"
Expand All @@ -55,7 +55,7 @@ SPDX-License-Identifier: Apache-2.0
</v-progress-circular>
<template v-else>
<v-icon
v-if="!!statusIcon"
v-if="hasStatusIcon"
size="small"
:color="color"
:icon="statusIcon"
Expand Down Expand Up @@ -236,6 +236,9 @@ export default {
isPending () {
return this.operationState === 'Pending'
},
isSucceeded () {
return this.operationState === 'Succeeded'
},
isTypeCreate () {
return this.operationType === 'Create'
},
Expand Down Expand Up @@ -270,7 +273,7 @@ export default {
if (this.isShootMarkedForDeletion) {
return 'mdi-delete-clock'
}
if (this.isTypeCreate) {
if (this.isTypeCreate && !this.isSucceeded) {
return 'mdi-plus'
}
if (this.isError) {
Expand All @@ -281,6 +284,9 @@ export default {
}
return undefined
},
hasStatusIcon () {
return !!this.statusIcon
},
statusTitle () {
const statusTitle = []
if (this.isShootStatusHibernationProgressing) {
Expand Down

0 comments on commit 774abe9

Please sign in to comment.