Correction of change order of backlog and sprints #105
Conversation
| @@ -74,7 +74,7 @@ def available_custom_fields | |||
| receiver.send :include, InstanceMethods | |||
| receiver.class_eval { | |||
| validate :validate_sprint | |||
| scope :without_version, :where => {:fixed_version_id => nil} | |||
| scope :without_version, :conditions => {:fixed_version_id => nil} | |||
There was a problem hiding this comment.
Use the new Ruby 1.9 hash syntax.
Space inside { missing.
Space inside } missing.
| @@ -51,7 +51,7 @@ def scrumbler_javascript_helper | |||
| } | |||
|
|
|||
|
|
|||
| javascript_tag "var Scrumbler = {}; Scrumbler.Translations = #{translations.to_json}; Scrumbler.root_url = '/'; Scrumbler.possible_points = #{ScrumblerIssueCustomField.points.possible_values.to_json};" | |||
| javascript_tag "var Scrumbler = {}; Scrumbler.Translations = #{translations.to_json}; Scrumbler.root_url = '../../'; Scrumbler.possible_points = #{ScrumblerIssueCustomField.points.possible_values.to_json};" | |||
| params[:issue] = HashWithIndifferentAccess.new({"custom_field_values" => { | ||
| ScrumblerIssueCustomField.priority.id.to_s => (priority).to_s | ||
| } | ||
| }) |
There was a problem hiding this comment.
Closing hash brace must be on the same line as the last hash element when opening brace is on the same line as the first hash element.
| @issues = @issues.map do |issue| | ||
| params[:issue] = HashWithIndifferentAccess.new({"custom_field_values" => { | ||
| ScrumblerIssueCustomField.priority.id.to_s => (priority).to_s | ||
| } |
There was a problem hiding this comment.
Indent the right brace the same as the first position after the preceding left parenthesis.
| end | ||
| @issues = @issues.map do |issue| | ||
| params[:issue] = HashWithIndifferentAccess.new({"custom_field_values" => { | ||
| ScrumblerIssueCustomField.priority.id.to_s => (priority).to_s |
There was a problem hiding this comment.
Use 2 spaces for indentation in a hash, relative to the first position after the preceding left parenthesis.
Don't use parentheses around a variable.
| priority = @issues.first.get_prioroty | ||
| end | ||
| @issues = @issues.map do |issue| | ||
| params[:issue] = HashWithIndifferentAccess.new({"custom_field_values" => { |
There was a problem hiding this comment.
Space inside { missing.
Redundant curly braces around a hash parameter.
| @@ -140,6 +140,21 @@ def move_issue_priority | |||
| @sprint = ScrumblerSprint.find(params[:sprint_id]) if params[:sprint_id] | |||
|
|
|||
| @issues = @issue.fixed_version ? @sprint.issues : @project.issues.without_version | |||
| @issues = @issues.sort_by{ |i| i.get_prioroty}.reverse | |||
| if [email protected]? | |||
There was a problem hiding this comment.
Favor unless over if for negative conditions.
| @@ -140,6 +140,21 @@ def move_issue_priority | |||
| @sprint = ScrumblerSprint.find(params[:sprint_id]) if params[:sprint_id] | |||
|
|
|||
| @issues = @issue.fixed_version ? @sprint.issues : @project.issues.without_version | |||
| @issues = @issues.sort_by{ |i| i.get_prioroty}.reverse | |||
There was a problem hiding this comment.
Space missing to the left of {.
Pass &:get_prioroty as an argument to sort_by instead of a block.
Space missing inside }.
No description provided.