Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] 2차과제 구현 완료#2 #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jeongdung-eo
Copy link
Contributor

🔥 Pull requests

⛳️ 작업한 브랜치

👷 작업한 내용

  • AutoLayout
  • Then 사용
  • Window 화면 전환
  • UIButton Configuration 사용

📸 스크린샷

과제 2

📟 관련 이슈

Copy link
Contributor

@meltsplit meltsplit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

환영인사

@@ -7,43 +7,144 @@
objects = {

/* Begin PBXBuildFile section */
02BE7490B9017B99796A3C5E /* Pods_First_Seminar.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = EB8BE4C14222BFF20A78A041 /* Pods_First_Seminar.framework */; };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신델리님 반갑습니다

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

신델리님 반갑습니다

네~ 전 신델리입니다~

Copy link
Member

@yungu0010 yungu0010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

김정은 최고 ~!🍀

Comment on lines +11 to +17
extension UIViewController{
func changeRootViewController(_ viewControllerToPresent: UIViewController) {
if let window = UIApplication.shared.windows.first {
window.rootViewController = viewControllerToPresent
UIView.transition(with: window, duration: 0.0, options: .transitionCrossDissolve, animations: nil)
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

익스텐션으로 빼준 거 정말 좋네요. .👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

누가 알려줬는지 모르겠지만 정말 환상적이네요 ^,^

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 잘하셨네요~~ 👍🏻

Comment on lines +31 to +33
$0.configuration?.image = UIImage(named:"profileImage")
$0.configuration?.contentInsets = NSDirectionalEdgeInsets.init(top: 0, leading: 0, bottom: 0, trailing: 0)
$0.configuration?.baseBackgroundColor = .clear
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

configuation 사용 멋있어요. . 🫶

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와 configuration 잘 쓰시네요! 배워갑니다!

Comment on lines +81 to +84
self.view.addSubview(deleteBtn)
self.view.addSubview(hStack)
self.view.addSubview(vStack)
self.view.addSubview(lineLabel)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

세미나 때 사용한 익스텐션을 사용해도 좋아보여용!!

Copy link

@daminoworld daminoworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아니 너무 잘 하시네요;; configuration 사용 배워갑니다!ㅎㅎ

Comment on lines +31 to +33
$0.configuration?.image = UIImage(named:"profileImage")
$0.configuration?.contentInsets = NSDirectionalEdgeInsets.init(top: 0, leading: 0, bottom: 0, trailing: 0)
$0.configuration?.baseBackgroundColor = .clear

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

우와 configuration 잘 쓰시네요! 배워갑니다!

Comment on lines +8 to +9
import Foundation
import UIKit

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UIKit에 Foundation이 기본적으로 import 되어 있어 두 개를 같이 쓸 필요가 없을 것 같습니다~~
간단히 찾아 봤는데

UIKit은 App과 같이 user interface를 사용할 때 import 해야 하는 것이다.
문자, 문자열 등 기본 객체나 Date 같은 것만 사용한다면 Foundation만 import해도 된다.

고 하네요! 출처: https://socialinnovator.tistory.com/6

import SnapKit

class ProfileViewController: UIViewController {
lazy var hStack = UIStackView().then {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스택 사용하는 법 배워갑니다.. 듣기로는 스택을 이용해서 쓰면 각자 자동으로 터치 영역이 구분이 된다고 하더라구요!!


}
func setConstrains(){
deleteBtn.snp.makeConstraints {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleteBtn 위치가 밑으로 내려오는 문제는 네비게이션바를 없애면서 해결할 수 있을 것 같아요~!!! 고생하셨어요!!!

Copy link

@6uohul 6uohul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코드가 간결하고 좋네요~!!
잘 보고갑니당 👍🏻

import SnapKit

class WelcomeViewController: UIViewController {
private lazy var titleLabel = UILabel().then {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오~ 저도 lazy var 썼어요 👍🏻

Comment on lines +11 to +17
extension UIViewController{
func changeRootViewController(_ viewControllerToPresent: UIViewController) {
if let window = UIApplication.shared.windows.first {
window.rootViewController = viewControllerToPresent
UIView.transition(with: window, duration: 0.0, options: .transitionCrossDissolve, animations: nil)
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

너무 잘하셨네요~~ 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] 2차 과제
6 participants