Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events.md: vpub numeration update #181

Merged
merged 2 commits into from
Feb 4, 2025
Merged

events.md: vpub numeration update #181

merged 2 commits into from
Feb 4, 2025

Conversation

Stanislaw-bnk
Copy link
Contributor

No description provided.

@Stanislaw-bnk Stanislaw-bnk self-assigned this Jan 30, 2025
@@ -43,14 +43,14 @@ all_events:
additional_info: |
### Dasharo User Group #10 **[Official Page](https://vpub.dasharo.com/e/18/dasharo-user-group-10)**<br><br>

- title: "Dasharo User Group 0x11 **& Developers vPub 0xG**"
- title: "Dasharo User Group 0x11 **& Developers vPub 0x10**"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Stanislaw-bnk if it's 11th DUG iteration, then you should use proper hex naming: 10th = 0xA, 11th = 0xB, and so on. vPub change is correct. Also, the naming convention differs from this site: https://vpub.dasharo.com/o/1 where we use #iteration. So, either use #11 or 0xB in this example.

Copy link
Contributor

@rafkoch rafkoch Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artur-rs thank you for finding this inconsistency.
I confirm that the following numbering applies:

  • decimal - for DUG (i.e. #.............)
  • hexadecimal for vPUB (i.e. 0x............)

So @Stanislaw-bnk please correct on the events main page all the DUG numbers starting from the first one, which wrongly has the number 0x1, because it should have #1.
On the posters and individual event pages it is OK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@rafkoch rafkoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@artur-rs we are waiting 4 your review nad merge.

@rafkoch rafkoch merged commit f32ceae into develop Feb 4, 2025
4 checks passed
@rafkoch
Copy link
Contributor

rafkoch commented Feb 4, 2025

@artur-rs I was merged this MR, because changes was obvious (in my opinion). I did it so as not to waste your time. If you still have comments, please let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants