Fix path calculation on maps with waterfalls and muddy slopes #643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Depending on which direction the pathfinding was checking a tile from, it was possible that it would get a _negative_ height of a waterfall or muddy slope. This led to the cost of that path becoming negative and potentially leading to an infinite loop. Fixes 40Cakes#640
hanzi
force-pushed
the
fix-path-calculation-for-waterfall-and-muddy-slope
branch
from
d00fb3d to
6184956
Compare
ThibaultLassiaz
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depending on which direction the pathfinding was checking a tile from, it was possible that it would get a negative height of a waterfall or muddy slope.
This led to the cost of that path becoming negative and potentially leading to an infinite loop.
Fixes #640
Checklist
--line-length 120argument