Merge Go up to 274f4ce.

SECURITY.md

@@ -2,7 +2,7 @@
 
 ## Supported Versions
 
-We support the past two Go releases (for example, Go 1.11.x and Go 1.12.x).
+We support the past two Go releases (for example, Go 1.12.x and Go 1.13.x).
 
 See https://golang.org/wiki/Go-Release-Cycle and in particular the
 [Release Maintenance](https://github.com/golang/go/wiki/Go-Release-Cycle#release-maintenance)

doc/articles/wiki/index.html

@@ -581,7 +581,7 @@ <h2>Validation</h2>
 
 <p>
 First, add <code>"regexp"</code> to the <code>import</code> list.
-Then we can create a global variable to store our validation 
+Then we can create a global variable to store our validation
 expression:
 </p>
 

doc/asm.html

@@ -832,27 +832,16 @@ <h3 id="arm64">ARM64</h3>
 Reference: <a href="/pkg/cmd/internal/obj/arm64">Go ARM64 Assembly Instructions Reference Manual</a>
 </p>
 
-<h3 id="ppc64">64-bit PowerPC, a.k.a. ppc64</h3>
+<h3 id="ppc64">PPC64</h3>
 
 <p>
-The 64-bit PowerPC port is in an experimental state.
+This assembler is used by GOARCH values ppc64 and ppc64le.
 </p>
 
 <p>
-Addressing modes:
+Reference: <a href="/pkg/cmd/internal/obj/ppc64">Go PPC64 Assembly Instructions Reference Manual</a>
 </p>
 
-<ul>
-
-<li>
-<code>(R5)(R6*1)</code>: The location at <code>R5</code> plus <code>R6</code>. It is a scaled
-mode as on the x86, but the only scale allowed is <code>1</code>.
-</li>
-
-<li>
-<code>(R5+R6)</code>: Alias for (R5)(R6*1)
-</li>
-
 </ul>
 
 <h3 id="s390x">IBM z/Architecture, a.k.a. s390x</h3>

doc/code.html

@@ -166,11 +166,6 @@ <h3 id="GOPATH">The <code>GOPATH</code> environment variable</h3>
 <a href="/cmd/go/#hdr-GOPATH_environment_variable"><code>'go help gopath'</code></a>.
 </p>
 
-<p>
-To use a custom workspace location,
-<a href="https://golang.org/wiki/SettingGOPATH">set the <code>GOPATH</code> environment variable</a>.
-</p>
-
 <h3 id="ImportPaths">Import paths</h3>
 
 <p>

doc/devel/release.html

@@ -30,6 +30,15 @@ <h2 id="go1.13">go1.13 (released 2019/09/03)</h2>
 Read the <a href="/doc/go1.13">Go 1.13 Release Notes</a> for more information.
 </p>
 
+<h3 id="go1.13.minor">Minor revisions</h3>
+
+<p>
+go1.13.1 (released 2019/09/25) includes security fixes to the
+<code>net/http</code> and <code>net/textproto</code> packages.
+See the <a href="https://github.com/golang/go/issues?q=milestone%3AGo1.13.1">Go
+1.13.1 milestone</a> on our issue tracker for details.
+</p>
+
 <h2 id="go1.12">go1.12 (released 2019/02/25)</h2>
 
 <p>
@@ -105,6 +114,13 @@ <h3 id="go1.12.minor">Minor revisions</h3>
 1.12.9 milestone</a> on our issue tracker for details.
 </p>
 
+<p>
+go1.12.10 (released 2019/09/25) includes security fixes to the
+<code>net/http</code> and <code>net/textproto</code> packages.
+See the <a href="https://github.com/golang/go/issues?q=milestone%3AGo1.12.10">Go
+1.12.10 milestone</a> on our issue tracker for details.
+</p>
+
 <h2 id="go1.11">go1.11 (released 2018/08/24)</h2>
 
 <p>

doc/effective_go.html

@@ -624,7 +624,7 @@ <h3 id="redeclaration">Redeclaration and reassignment</h3>
 <li>this declaration is in the same scope as the existing declaration of <code>v</code>
 (if <code>v</code> is already declared in an outer scope, the declaration will create a new variable §),</li>
 <li>the corresponding value in the initialization is assignable to <code>v</code>, and</li>
-<li>there is at least one other variable in the declaration that is being declared anew.</li>
+<li>there is at least one other variable that is created by the declaration.</li>
 </ul>
 
 <p>

doc/gccgo_contribute.html

@@ -105,7 +105,7 @@ <h2>Submitting Changes</h2>
 <p>
 Changes to the Go frontend should follow the same process as for the
 main Go repository, only for the <code>gofrontend</code> project and
-the <code>[email protected]</code> mailing list 
+the <code>[email protected]</code> mailing list
 rather than the <code>go</code> project and the
 <code>[email protected]</code> mailing list.  Those changes
 will then be merged into the GCC sources.

doc/gccgo_install.html

@@ -80,7 +80,7 @@ <h2 id="Source_code">Source code</h2>
 
 <p>
 If you cannot use a release, or prefer to build gccgo for
-yourself, 
+yourself,
 the gccgo source code is accessible via Subversion. The
 GCC web site
 has <a href="https://gcc.gnu.org/svn.html">instructions for getting the

doc/go1.13.html

@@ -102,7 +102,7 @@ <h2 id="language">Changes to the language</h2>
 
 <h2 id="ports">Ports</h2>
 
-<p>
+<p id="nacl">
   Go 1.13 is the last release that will run on Native Client (NaCl).
 </p>
 
@@ -821,7 +821,7 @@ <h3 id="minor_library_changes">Minor changes to the library</h3>
     <p><!-- CL 154383 -->
       <a href="/pkg/net/http/#TimeoutHandler"><code>TimeoutHandler</code></a>'s
       <a href="/pkg/net/http/#ResponseWriter"><code>ResponseWriter</code></a> now implements the
-      <a href="/pkg/net/http/#Pusher"><code>Pusher</code></a> and <a href="/pkg/net/http/#Flusher"><code>Flusher</code></a> interfaces.
+      <a href="/pkg/net/http/#Pusher"><code>Pusher</code></a> interface.
     </p>
 
     <p><!-- CL 157339 -->

doc/go1.14.html

@@ -115,6 +115,19 @@ <h2 id="library">Core library</h2>
 
 </dl><!-- plugin -->
 
+<dl id="reflect">
+
+<dt><a href="/pkg/reflect/">reflect</a></dt>
+  <dd>
+    <p><!-- CL 85661 -->
+      <a href="/pkg/reflect#StructOf"><code>StructOf</code></a> now
+      supports creating struct types with unexported fields, by
+      setting the <code>PkgPath</code> field in
+      a <code>StructField</code> element.
+    </p>
+
+</dl><!-- reflect -->
+
 <dl id="runtime"><dt><a href="/pkg/runtime/">runtime</a></dt>
   <dd>
     <p><!-- CL 187739 -->

doc/go_faq.html

@@ -39,7 +39,7 @@ <h3 id="What_is_the_purpose_of_the_project">
 
 <p>
 These considerations led to
-<a href="https://commandcenter.blogspot.com/2017/09/go-ten-years-and-climbing.html">a 
+<a href="https://commandcenter.blogspot.com/2017/09/go-ten-years-and-climbing.html">a
 series of discussions</a> from which Go arose, first as a set of ideas and
 desiderata, then as a language.
 An overarching goal was that Go do more to help the working programmer
@@ -1282,7 +1282,7 @@ <h3 id="git_https">
 
 <p>
 Companies often permit outgoing traffic only on the standard TCP ports 80 (HTTP)
-and 443 (HTTPS), blocking outgoing traffic on other ports, including TCP port 9418 
+and 443 (HTTPS), blocking outgoing traffic on other ports, including TCP port 9418
 (git) and TCP port 22 (SSH).
 When using HTTPS instead of HTTP, <code>git</code> enforces certificate validation by
 default, providing protection against man-in-the-middle, eavesdropping and tampering attacks.

misc/cgo/test/cgo_test.go

@@ -91,5 +91,6 @@ func TestThreadLock(t *testing.T)            { testThreadLockFunc(t) }
 func TestUnsignedInt(t *testing.T)           { testUnsignedInt(t) }
 func TestZeroArgCallback(t *testing.T)       { testZeroArgCallback(t) }
 
-func BenchmarkCgoCall(b *testing.B)  { benchCgoCall(b) }
-func BenchmarkGoString(b *testing.B) { benchGoString(b) }
+func BenchmarkCgoCall(b *testing.B)     { benchCgoCall(b) }
+func BenchmarkGoString(b *testing.B)    { benchGoString(b) }
+func BenchmarkCGoCallback(b *testing.B) { benchCallback(b) }

misc/cgo/test/test.go

@@ -1000,6 +1000,17 @@ func benchCgoCall(b *testing.B) {
 	}
 }
 
+// Benchmark measuring overhead from Go to C and back to Go (via a callback)
+func benchCallback(b *testing.B) {
+	var x = false
+	for i := 0; i < b.N; i++ {
+		nestedCall(func() { x = true })
+	}
+	if !x {
+		b.Fatal("nestedCall was not invoked")
+	}
+}
+
 var sinkString string
 
 func benchGoString(b *testing.B) {

misc/trace/trace_viewer_full.html

@@ -397,23 +397,23 @@
     <span id="content"></span>
 
     <span id="significance">
-      
+
       <svg id="insignificant" viewBox="0 0 128 128">
         <circle cx="64" cy="64" r="60"></circle>
         <circle cx="44" cy="44" r="4"></circle>
         <circle cx="84" cy="44" r="4"></circle>
         <line x1="36" x2="92" y1="80" y2="80"></line>
       </svg>
 
-      
+
       <svg id="significantly_better" viewBox="0 0 128 128">
         <circle cx="64" cy="64" r="60"></circle>
         <circle cx="44" cy="44" r="4"></circle>
         <circle cx="84" cy="44" r="4"></circle>
         <path d="M 28 64 Q 64 128 100 64"></path>
       </svg>
 
-      
+
       <svg id="significantly_worse" viewBox="0 0 128 128">
         <circle cx="64" cy="64" r="60"></circle>
         <circle cx="44" cy="44" r="4"></circle>
@@ -677,7 +677,7 @@
 
   <div id="header"></div>
   <input id="stacking-distance-slider" max="400" min="1" step="1" type="range"/>
-  
+
   <canvas id="canvas"></canvas>
   <img id="chrome-left"/>
   <img id="chrome-mid"/>
@@ -815,7 +815,7 @@
     <label id="label"></label>
   </template>
 </dom-module><template id="chart-base-template">
-  <svg> 
+  <svg>
     <g id="chart-area" xmlns="http://www.w3.org/2000/svg">
       <g class="x axis"></g>
       <g class="y axis"></g>
@@ -1185,7 +1185,7 @@ <h1 id="blink_rcs_heading"></h1>
       <div id="label">Heap details</div>
       <div id="view_mode_container">
         <span>View mode:</span>
-        
+
       </div>
     </div>
     <div id="contents">
@@ -1392,11 +1392,11 @@ <h1 id="blink_rcs_heading"></h1>
         font-size: 15px;
       }
     </style>
-    
+
     <div id="label"></div>
     <div id="aggregation_mode_container">
       <span>Metric aggregation:</span>
-      
+
     </div>
   </template>
 </dom-module><dom-module id="tr-ui-a-stacked-pane-view">
@@ -1450,7 +1450,7 @@ <h1 id="blink_rcs_heading"></h1>
     </style>
     <tr-ui-b-table id="table">
     </tr-ui-b-table>
-    
+
   </template>
 </dom-module><dom-module id="tr-ui-a-selection-summary-table">
   <template>
@@ -1466,7 +1466,7 @@ <h1 id="blink_rcs_heading"></h1>
     </style>
     <tr-ui-b-table id="table">
     </tr-ui-b-table>
-    
+
   </template>
 </dom-module><dom-module id="tr-ui-b-radio-picker">
   <template>

misc/wasm/wasm_exec.js

@@ -308,6 +308,11 @@
 						Reflect.set(loadValue(sp + 8), loadString(sp + 16), loadValue(sp + 32));
 					},
 
+					// func valueDelete(v ref, p string)
+					"syscall/js.valueDelete": (sp) => {
+						Reflect.deleteProperty(loadValue(sp + 8), loadString(sp + 16));
+					},
+
 					// func valueIndex(v ref, i int) ref
 					"syscall/js.valueIndex": (sp) => {
 						storeValue(sp + 24, Reflect.get(loadValue(sp + 8), getInt64(sp + 16)));
@@ -457,12 +462,13 @@
 			this.argv.forEach((arg) => {
 				argvPtrs.push(strPtr(arg));
 			});
+			argvPtrs.push(0);
 
 			const keys = Object.keys(this.env).sort();
-			argvPtrs.push(keys.length);
 			keys.forEach((key) => {
 				argvPtrs.push(strPtr(`${key}=${this.env[key]}`));
 			});
+			argvPtrs.push(0);
 
 			const argv = offset;
 			argvPtrs.forEach((ptr) => {

src/bytes/bytes.go

@@ -935,7 +935,8 @@ func ReplaceAll(s, old, new []byte) []byte {
 }
 
 // EqualFold reports whether s and t, interpreted as UTF-8 strings,
-// are equal under Unicode case-folding.
+// are equal under Unicode case-folding, which is a more general
+// form of case-insensitivity.
 func EqualFold(s, t []byte) bool {
 	for len(s) != 0 && len(t) != 0 {
 		// Extract first rune from each.

src/cmd/asm/internal/arch/ppc64.go

@@ -47,7 +47,7 @@ func IsPPC64ISEL(op obj.As) bool {
 // one of the CMP instructions that require special handling.
 func IsPPC64CMP(op obj.As) bool {
 	switch op {
-	case ppc64.ACMP, ppc64.ACMPU, ppc64.ACMPW, ppc64.ACMPWU:
+	case ppc64.ACMP, ppc64.ACMPU, ppc64.ACMPW, ppc64.ACMPWU, ppc64.AFCMPU:
 		return true
 	}
 	return false

src/cmd/asm/internal/arch/s390x.go

@@ -15,7 +15,8 @@ import (
 
 func jumpS390x(word string) bool {
 	switch word {
-	case "BC",
+	case "BRC",
+		"BC",
 		"BCL",
 		"BEQ",
 		"BGE",
@@ -41,6 +42,14 @@ func jumpS390x(word string) bool {
 		"CMPUBLE",
 		"CMPUBLT",
 		"CMPUBNE",
+		"CRJ",
+		"CGRJ",
+		"CLRJ",
+		"CLGRJ",
+		"CIJ",
+		"CGIJ",
+		"CLIJ",
+		"CLGIJ",
 		"CALL",
 		"JMP":
 		return true

src/cmd/asm/internal/asm/asm.go

@@ -450,8 +450,19 @@ func (p *Parser) asmJump(op obj.As, cond string, a []obj.Addr) {
 			target = &a[2]
 			break
 		}
-
-		fallthrough
+		p.errorf("wrong number of arguments to %s instruction", op)
+		return
+	case 4:
+		if p.arch.Family == sys.S390X {
+			// 4-operand compare-and-branch.
+			prog.From = a[0]
+			prog.Reg = p.getRegister(prog, op, &a[1])
+			prog.SetFrom3(a[2])
+			target = &a[3]
+			break
+		}
+		p.errorf("wrong number of arguments to %s instruction", op)
+		return
 	default:
 		p.errorf("wrong number of arguments to %s instruction", op)
 		return