Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple row project seg fault #3712

Closed
aceforeverd opened this issue Jan 21, 2024 · 1 comment · Fixed by #3713
Closed

simple row project seg fault #3712

aceforeverd opened this issue Jan 21, 2024 · 1 comment · Fixed by #3713
Assignees
Labels
bug Something isn't working execute-engine hybridse sql engine high-priority

Comments

@aceforeverd
Copy link
Collaborator

- id: 0
  sql: select c1 + 8 from (select 9 as c1)

it generate the physical project :

PROJECT(type=RowProject)
  CONST_PROJECT

ConstProjectRunner output MemTableHandler:

auto output_table = std::shared_ptr<MemTableHandler>(new MemTableHandler());
output_table->AddRow(project_gen_.Gen(ctx.GetParameterRow()));
return output_table;

but from RowProjectRunner expect RowHandler
auto row = std::dynamic_pointer_cast<RowHandler>(inputs[0]);
return std::shared_ptr<RowHandler>(
new MemRowHandler(project_gen_.Gen(row->GetValue(), ctx.GetParameterRow())));

@aceforeverd aceforeverd added bug Something isn't working high-priority execute-engine hybridse sql engine labels Jan 21, 2024
@aceforeverd aceforeverd self-assigned this Jan 21, 2024
@aceforeverd
Copy link
Collaborator Author

  1. RowProject & SimpleProject actually just diffs at optimize level, there is no difference in codegen and runner. It can easily archived in single physical node for same purpose, just add a extra class method to check the difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working execute-engine hybridse sql engine high-priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant