feat(codec): encode/decode map value to codec row #3713

aceforeverd · 2024-01-22T03:06:57Z

also give a quick fix to #3712

codecov · 2024-01-22T10:11:48Z

Codecov Report

Attention: Patch coverage is 86.16000% with 173 lines in your changes are missing coverage. Please review.

Project coverage is 74.92%. Comparing base (0003109) to head (fb76df3).
Report is 2 commits behind head on main.

Files	Patch %	Lines
hybridse/src/codegen/map_ir_builder.cc	90.47%	36 Missing ⚠️
hybridse/src/codegen/ir_base_builder.cc	69.38%	30 Missing ⚠️
hybridse/src/codegen/buf_ir_builder.cc	91.39%	26 Missing ⚠️
hybridse/src/codec/fe_row_codec.cc	77.00%	23 Missing ⚠️
hybridse/src/codec/type_codec.cc	41.17%	10 Missing ⚠️
hybridse/src/codegen/context.cc	81.25%	9 Missing ⚠️
hybridse/src/node/expr_node.cc	75.75%	8 Missing ⚠️
hybridse/src/vm/runner.cc	57.89%	8 Missing ⚠️
hybridse/src/codegen/window_ir_builder.cc	69.56%	7 Missing ⚠️
hybridse/src/codegen/buf_ir_builder_test.cc	92.95%	5 Missing ⚠️
... and 4 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3713      +/-   ##
============================================
+ Coverage     74.91%   74.92%   +0.01%     
  Complexity      658      658              
============================================
  Files           737      738       +1     
  Lines        132541   133155     +614     
  Branches       1380     1380              
============================================
+ Hits          99290    99771     +481     
- Misses        32947    33080     +133     
  Partials        304      304

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hybridse/src/udf/literal_traits.h

This updated proto defines for `hybridse::type::ColumnDef`, old data type field `ColumnDef::type`, as well as `ColumnDef::is_not_null` consider deprecated, and `ColumnDef::schema` consider the new data type for new codes. Old fields still workable but may going to removed in further release.

github-actions · 2024-02-28T04:57:51Z

SDK Test Report

101 files ±0 101 suites ±0 2m 20s ⏱️ +13s
345 tests ±0 331 ✅ ±0 14 💤 ±0 0 ❌ ±0
471 runs ±0 457 ✅ ±0 14 💤 ±0 0 ❌ ±0

Results for commit fb76df3. ± Comparison against base commit 0003109.

This pull request removes 42 and adds 21 tests. Note that renamed tests count towards both.

  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…

com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.openmldb.jdbc.SQLRouterSmokeTest ‑ testInsertMeta[com._4paradigm.openmldb.sdk.impl.SqlClusterExecutor@6d7556a8](2)
…

♻️ This comment has been updated with latest results.

github-actions · 2024-02-28T05:13:03Z

HybridSE Mac Test Report

20 118 tests 20 116 ✅ 11m 6s ⏱️
255 suites 2 💤
67 files 0 ❌

Results for commit fb76df3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-28T05:13:05Z

HybridSE Linux Test Report

20 118 tests 20 116 ✅ 6m 6s ⏱️
255 suites 2 💤
67 files 0 ❌

Results for commit fb76df3.

♻️ This comment has been updated with latest results.

github-actions · 2024-02-28T06:00:41Z

Linux Test Report

57 files ± 0 244 suites ±0 1h 18m 30s ⏱️ + 1m 12s
12 618 tests +33 12 611 ✅ +33 7 💤 ±0 0 ❌ ±0
17 890 runs +48 17 883 ✅ +48 7 💤 ±0 0 ❌ ±0

Results for commit fb76df3. ± Comparison against base commit 0003109.

♻️ This comment has been updated with latest results.

github-actions bot added build openmldb compiling and installing execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Jan 22, 2024

aceforeverd force-pushed the feat-map-storage branch 3 times, most recently from 2ef30f5 to 31867ac Compare January 22, 2024 09:51

aceforeverd force-pushed the feat-map-storage branch 2 times, most recently from 6cc89a2 to 1956cc0 Compare January 24, 2024 07:23

github-actions bot removed the build openmldb compiling and installing label Jan 24, 2024

aceforeverd commented Feb 1, 2024

View reviewed changes

hybridse/src/udf/literal_traits.h Outdated Show resolved Hide resolved

aceforeverd added 2 commits February 28, 2024 04:25

feat(codec): encode map type into row

c16b264

aceforeverd force-pushed the feat-map-storage branch from 1956cc0 to ae12921 Compare February 28, 2024 04:25

feat: rm ImmutableMap

fb76df3

aceforeverd force-pushed the feat-map-storage branch from ae12921 to fb76df3 Compare February 28, 2024 09:16

aceforeverd requested review from tobegit3hub, dl239 and vagetablechicken February 28, 2024 09:44

aceforeverd linked an issue Feb 28, 2024 that may be closed by this pull request

simple row project seg fault #3712

Closed

dl239 approved these changes Feb 28, 2024

View reviewed changes

vagetablechicken approved these changes Feb 29, 2024

View reviewed changes

aceforeverd merged commit 7f1bd83 into 4paradigm:main Feb 29, 2024
31 checks passed

aceforeverd deleted the feat-map-storage branch February 29, 2024 02:15

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(codec): encode/decode map value to codec row #3713

feat(codec): encode/decode map value to codec row #3713

aceforeverd commented Jan 22, 2024

codecov bot commented Jan 22, 2024 •

edited

Loading

github-actions bot commented Feb 28, 2024 •

edited

Loading

github-actions bot commented Feb 28, 2024 •

edited

Loading

github-actions bot commented Feb 28, 2024 •

edited

Loading

github-actions bot commented Feb 28, 2024 •

edited

Loading

feat(codec): encode/decode map value to codec row #3713

feat(codec): encode/decode map value to codec row #3713

Conversation

aceforeverd commented Jan 22, 2024

codecov bot commented Jan 22, 2024 • edited Loading

Codecov Report

github-actions bot commented Feb 28, 2024 • edited Loading

SDK Test Report

github-actions bot commented Feb 28, 2024 • edited Loading

HybridSE Mac Test Report

github-actions bot commented Feb 28, 2024 • edited Loading

HybridSE Linux Test Report

github-actions bot commented Feb 28, 2024 • edited Loading

Linux Test Report

codecov bot commented Jan 22, 2024 •

edited

Loading

github-actions bot commented Feb 28, 2024 •

edited

Loading

github-actions bot commented Feb 28, 2024 •

edited

Loading

github-actions bot commented Feb 28, 2024 •

edited

Loading

github-actions bot commented Feb 28, 2024 •

edited

Loading