Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: recoverdata and log print #3545

Merged
merged 4 commits into from
Oct 31, 2023

Conversation

vagetablechicken
Copy link
Collaborator

image

@vagetablechicken
Copy link
Collaborator Author

vagetablechicken commented Oct 10, 2023

if (ok && response.code() == 0) {

tablet client LoadTable should show error msg, next pr

@vagetablechicken
Copy link
Collaborator Author

vagetablechicken commented Oct 10, 2023

recover may block by failed table, should try recover all, instead of return? done

@vagetablechicken
Copy link
Collaborator Author

vagetablechicken commented Oct 10, 2023

if (!::openmldb::base::IsExists(db_path)) {
nameserver say a replica should be on tablet, but tablet doesn't have the tid-pid dir on db_path, it's not a big problem, we just save metadata from loadtable request, but the code block and return. Just create one?
Next pr with table client error

@vagetablechicken vagetablechicken changed the title fix: ops log print fix: recoverdata and log print Oct 11, 2023
tools/openmldb_ops.py Outdated Show resolved Hide resolved
tools/tool.py Outdated Show resolved Hide resolved
@vagetablechicken vagetablechicken merged commit eeb37b6 into 4paradigm:main Oct 31, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants