feat(sql): window without order by #3554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #3554 +/- ##
=============================================
- Coverage 83.35% 75.32% -8.03%
- Complexity 0 587 +587
=============================================
Files 17 718 +701
Lines 751 129786 +129035
Branches 0 1280 +1280
=============================================
+ Hits 626 97766 +97140
- Misses 109 31734 +31625
- Partials 16 286 +270
☔ View full report in Codecov by Sentry. |
aceforeverd
force-pushed
the
feat-window-without-order-by
branch
from
3fec6a9 to
208483e
Compare
aceforeverd
force-pushed
the
feat-window-without-order-by
branch
from
208483e to
4776940
Compare
aceforeverd
added a commit
to aceforeverd/fedb
that referenced
this pull request
Oct 16, 2023
SQL changes mainly from 4paradigm#3533 and 4paradigm#3554
aceforeverd
added a commit
to aceforeverd/fedb
that referenced
this pull request
Oct 16, 2023
SQL changes mainly from 4paradigm#3533 and 4paradigm#3554
Rules: - ALLOWED for ROWS-type WINDOW - NOT ALLOWED for RANGE-type WINDOW with offset PRECEDING/FOLLOWING - NOT ALLOWED for WINDOW with attribute EXCLUDE CURRENT_TIME Without ORDER BY, rows are processed in an unspecified order.
aceforeverd
force-pushed
the
feat-window-without-order-by
branch
from
4776940 to
b30b42d
Compare
|
TODO afterwards: fix auto-create-index logic during deployment, I don't cover that. |
dl239
approved these changes
Nov 8, 2023
lqy222
approved these changes
Nov 9, 2023
This was referenced Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rules:
Usage notice for WINDOW without ORDER BY clause:
lag, first_value, ..., depend on the sort ordering specified by the ORDER BY clause of the associated window definition. In which case, MAY returns undetermined result