Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(iterator): simplify virtual function list #3571

Closed
wants to merge 2 commits into from

Conversation

aceforeverd
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Oct 27, 2023
@aceforeverd aceforeverd force-pushed the refactor-iterators branch 2 times, most recently from c708367 to 08ad04e Compare October 27, 2023 02:05
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 198 lines in your changes are missing coverage. Please review.

Comparison is base (23d7c50) 75.31% compared to head (29d906b) 75.33%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3571      +/-   ##
============================================
+ Coverage     75.31%   75.33%   +0.02%     
  Complexity      587      587              
============================================
  Files           719      717       -2     
  Lines        129836   129880      +44     
  Branches       1280     1280              
============================================
+ Hits          97787    97850      +63     
+ Misses        31763    31760       -3     
+ Partials        286      270      -16     
Files Coverage Δ
...bridse/examples/toydb/src/tablet/tablet_catalog.cc 66.66% <ø> (+9.34%) ⬆️
...amples/toydb/src/testing/toydb_engine_test_base.cc 73.46% <100.00%> (-0.54%) ⬇️
hybridse/include/codec/row.h 95.00% <100.00%> (ø)
hybridse/include/codec/row_list.h 89.28% <100.00%> (+24.06%) ⬆️
hybridse/include/vm/simple_catalog.h 80.00% <ø> (ø)
...idse/src/passes/physical/batch_request_optimize.cc 90.62% <100.00%> (+0.26%) ⬆️
...dse/src/passes/physical/group_and_sort_optimized.h 100.00% <100.00%> (ø)
...e/src/passes/physical/transform_up_physical_pass.h 75.00% <ø> (ø)
hybridse/src/plan/planner.cc 88.27% <100.00%> (ø)
hybridse/src/testing/engine_test_base.cc 80.54% <100.00%> (+0.04%) ⬆️
... and 19 more

... and 20 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aceforeverd
Copy link
Collaborator Author

included in #3576

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant