Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: put returns failure if the server memory usage exceeds the specified ratio #3631

Merged
merged 13 commits into from
Jan 15, 2024

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Nov 28, 2023

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (ebe1f7d) 40.25% compared to head (5e67748) 74.97%.

Files Patch % Lines
src/sdk/sql_cluster_router.cc 28.57% 10 Missing ⚠️
src/base/sys_info.h 80.95% 8 Missing ⚠️
src/tablet/tablet_impl.cc 74.07% 7 Missing ⚠️
.../com/_4paradigm/openmldb/spark/OpenmldbSource.java 0.00% 4 Missing ⚠️
...a/com/_4paradigm/openmldb/spark/OpenmldbTable.java 0.00% 3 Missing ⚠️
src/client/tablet_client.cc 81.25% 3 Missing ⚠️
...digm/openmldb/spark/write/OpenmldbWriteConfig.java 0.00% 2 Missing ⚠️
...openmldb/spark/write/OpenmldbDataSingleWriter.java 0.00% 1 Missing ⚠️
...adigm/openmldb/spark/write/OpenmldbDataWriter.java 0.00% 1 Missing ⚠️
src/datacollector/data_collector.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3631       +/-   ##
=============================================
+ Coverage     40.25%   74.97%   +34.72%     
  Complexity      642      642               
=============================================
  Files           192      727      +535     
  Lines         11277   130895   +119618     
  Branches       1323     1324        +1     
=============================================
+ Hits           4539    98137    +93598     
- Misses         6445    32465    +26020     
  Partials        293      293               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 linked an issue Nov 28, 2023 that may be closed by this pull request
@github-actions github-actions bot added the sdk openmldb java/python sdk label Nov 30, 2023
@github-actions github-actions bot removed the sdk openmldb java/python sdk label Dec 1, 2023
@dl239 dl239 marked this pull request as ready for review December 1, 2023 09:07
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 1, 2023
src/tablet/tablet_impl.cc Outdated Show resolved Hide resolved
src/base/sys_info_test.cc Outdated Show resolved Hide resolved
src/base/sys_info.h Show resolved Hide resolved
src/base/sys_info.h Outdated Show resolved Hide resolved
src/base/sys_info_test.cc Outdated Show resolved Hide resolved
src/base/sys_info.h Show resolved Hide resolved
src/base/sys_info.h Outdated Show resolved Hide resolved
@dl239 dl239 merged commit 7b88a80 into 4paradigm:main Jan 15, 2024
24 checks passed
@dl239 dl239 deleted the feat/limit_put_memory branch January 15, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-server documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importing a large volume of data may lead to server out-of-memory (OOM)
3 participants