Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: support build on no tag #3641

Merged
merged 3 commits into from
Dec 4, 2023
Merged

build: support build on no tag #3641

merged 3 commits into from
Dec 4, 2023

Conversation

vagetablechicken
Copy link
Collaborator

@vagetablechicken vagetablechicken commented Nov 29, 2023

if REF set empty, branch or commit, failed on grep HEAD. Ignore this error, just use snapshot to be the version. The doc is correct, no update about it.

zetasql lib built by workflow run is wierd, but can't solve it now. So we add zetasql lib url to replace it in workflow.

@github-actions github-actions bot added the workflow CICD related label Nov 29, 2023
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71cf61e) 74.94% compared to head (fd418aa) 40.16%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3641       +/-   ##
=============================================
- Coverage     74.94%   40.16%   -34.79%     
  Complexity      640      640               
=============================================
  Files           724      191      -533     
  Lines        130414    11233   -119181     
  Branches       1325     1325               
=============================================
- Hits          97743     4512    -93231     
+ Misses        32378     6428    -25950     
  Partials        293      293               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

SDK Test Report

100 files  ±0  100 suites  ±0   2m 3s ⏱️ -1s
327 tests ±0  314 ✔️ ±0  13 💤 ±0  0 ±0 
444 runs  ±0  431 ✔️ ±0  13 💤 ±0  0 ±0 

Results for commit fd418aa. ± Comparison against base commit 71cf61e.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Nov 29, 2023

Linux Test Report

  52 files   -        2    59 suites   - 55   27m 9s ⏱️ - 22m 22s
650 tests  - 6 246  641 ✔️  - 6 248  7 💤 ±0  2 +2 
651 runs   - 6 246  642 ✔️  - 6 248  7 💤 ±0  2 +2 

For more details on these failures, see this check.

Results for commit 5dbfa78. ± Comparison against base commit 71cf61e.

This pull request removes 6246 tests.
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/0
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/1
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/10
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/11
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/12
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/13
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/14
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/2
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/3
LimitClauseQuery/SQLSDKQueryTest ‑ SqlSdkBatchRequestTest/4
…

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@tobegit3hub tobegit3hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobegit3hub tobegit3hub merged commit a8c0226 into main Dec 4, 2023
21 of 23 checks passed
@tobegit3hub tobegit3hub deleted the other-os-build-fix branch December 4, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow CICD related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants