Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display deployment options #3682

Merged
merged 3 commits into from
Jan 16, 2024

Conversation

dl239
Copy link
Collaborator

@dl239 dl239 commented Dec 26, 2023

close #2386

@github-actions github-actions bot added execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet labels Dec 26, 2023
@dl239 dl239 marked this pull request as ready for review December 26, 2023 07:53
Copy link

codecov bot commented Dec 26, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (a112872) 78.27% compared to head (369e98f) 74.91%.

Files Patch % Lines
src/cmd/display.h 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3682      +/-   ##
============================================
- Coverage     78.27%   74.91%   -3.37%     
- Complexity        0      654     +654     
============================================
  Files           553      729     +176     
  Lines        120481   131099   +10618     
  Branches          0     1341    +1341     
============================================
+ Hits          94312    98211    +3899     
- Misses        26153    32589    +6436     
- Partials         16      299     +283     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dl239 dl239 merged commit 1a29c06 into 4paradigm:main Jan 16, 2024
27 of 29 checks passed
@dl239 dl239 deleted the feat/show_create_deployment branch January 16, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execute-engine hybridse sql engine storage-engine openmldb storage engine. nameserver & tablet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show DeployOptions
3 participants