Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: insert error improve #3725

Merged
merged 8 commits into from
Feb 6, 2024

Conversation

vagetablechicken
Copy link
Collaborator

#3708 print failed column value if trans failed
print failed row when load data failed
apiserver print col/row or idx

4paradigm#3708 print failed column value if trans failed
print failed row when load data failed
apiserver print col/row or idx
@github-actions github-actions bot added documentation Improvements or additions to documentation api-server labels Jan 25, 2024
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 178 lines in your changes are missing coverage. Please review.

Comparison is base (7d755ff) 40.18% compared to head (de3cef5) 74.88%.

Files Patch % Lines
src/apiserver/api_server_test.cc 0.00% 87 Missing ⚠️
src/apiserver/api_server_impl.cc 0.00% 60 Missing ⚠️
src/sdk/sql_cluster_router.cc 33.33% 20 Missing ⚠️
...adigm/openmldb/spark/write/OpenmldbDataWriter.java 0.00% 8 Missing ⚠️
src/apiserver/api_server_impl.h 0.00% 2 Missing ⚠️
...openmldb/spark/write/OpenmldbDataSingleWriter.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #3725       +/-   ##
=============================================
+ Coverage     40.18%   74.88%   +34.69%     
  Complexity      655      655               
=============================================
  Files           193      732      +539     
  Lines         11384   131680   +120296     
  Branches       1366     1367        +1     
=============================================
+ Hits           4575    98602    +94027     
- Misses         6510    32779    +26269     
  Partials        299      299               

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jan 31, 2024

SDK Test Report

101 files  ±0  101 suites  ±0   2m 10s ⏱️ +3s
344 tests ±0  330 ✅ ±0  14 💤 ±0  0 ❌ ±0 
469 runs  ±0  455 ✅ ±0  14 💤 ±0  0 ❌ ±0 

Results for commit 28676c7. ± Comparison against base commit 3deb139.

This pull request removes 30 and adds 9 tests. Note that renamed tests count towards both.
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
 ) limit 10;](2)
 ) limit 10;](3)
 FROM db1.t1
 FROM t1
 WINDOW w1 AS (
 last join db2.t2 order by db2.t2.col1
…
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[db1,  SELECT sum(t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlLastJoinWithMultipleDB[null,  SELECT sum(db1.t1.col1) over w1 as sum_t1_col1, db2.t2.str1 as t2_str1
 FROM db1.t1
 last join db2.t2 order by db2.t2.col1
 on db1.t1.col1 = db2.t2.col1 and db1.t1.col2 = db2.t2.col0
 WINDOW w1 AS (
  PARTITION BY db1.t1.col2 ORDER BY db1.t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](4)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db1.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: db1.t2.str1](2)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.col1](3)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[db1, SELECT t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Column Not found: .t2.str1](1)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlMultipleDBErrorTest[null, SELECT db2.t2.str1 as t2_str1
 FROM t1
 last join db2.t2 order by db2.t2.col1
 on t1.col1 = db2.t2.col1 and t1.col2 = db2.t2.col0;
, SQL parse error: Fail to transform data provider op: table t1 not exists in database []](5)
com._4paradigm.hybridse.sdk.SqlEngineTest ‑ sqlWindowLastJoin[ SELECT sum(t1.col1) over w1 as sum_t1_col1, t2.str1 as t2_str1
 FROM t1
 last join t2 order by t2.col1
 on t1.col1 = t2.col1 and t1.col2 = t2.col0
 WINDOW w1 AS (
  PARTITION BY t1.col2 ORDER BY t1.col1
  ROWS_RANGE BETWEEN 3 PRECEDING AND CURRENT ROW
 ) limit 10;](1)

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 31, 2024

Linux Test Report

    57 files  +    57     244 suites  +244   1h 18m 40s ⏱️ + 1h 18m 40s
12 578 tests +12 578  12 571 ✅ +12 571  7 💤 +7  0 ❌ ±0 
17 835 runs  +17 835  17 828 ✅ +17 828  7 💤 +7  0 ❌ ±0 

Results for commit 28676c7. ± Comparison against base commit 3deb139.

♻️ This comment has been updated with latest results.

@vagetablechicken
Copy link
Collaborator Author

coverage workflow failed cuz other commit, will be fixed asap

@vagetablechicken vagetablechicken merged commit 0836cd0 into 4paradigm:main Feb 6, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-server documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants