Add support for sorted sets, lrange and transactions #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecsl
changed the title
felipecsl
changed the title
felipecsl
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
This adds support for:
zaddzrangezrevrangezrangeWithScoreszrangeByScorezrangeByScoreWithScoreszrevrangeByScoreWithScoreszrevrangeByScorelrangezrankzremrangeByRankzremrangeByScorezcardzscoremulti,exec,discardIf you don't mind, I've converted the files from tab to 2-space indentation and removed
finalfrom parameters and local variables to clean up the code. If you feel strongly, I can add those back, but I deem them unnecessary :)Also a couple other housekeeping Gradle improvements, added unit tests.
If you add
?w=1to the PR url, it's gonna ignore whitespace-only changes. (easier to review)It's worth mentioning that the time complexity is not quite the same as the Redis default implementation (
O(log(N)+M)versusO(N)in this implementation), but I guess that's fine for a test-only library