Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non SRD monsters #119

Merged
merged 2 commits into from
Dec 10, 2019
Merged

Remove non SRD monsters #119

merged 2 commits into from
Dec 10, 2019

Conversation

ogregoire
Copy link
Collaborator

Fixes #112
Removes the following monsters:

  • Adult Blue Dracolich
  • Carrion Crawler
  • Cave Bear

@bagelbits
Copy link
Collaborator

You're going to hate me for this, but should we adjust the index of the rest of the monsters?

@bagelbits
Copy link
Collaborator

I'd highly recommend doing this programmatically if possible. Otherwise, it's going to be a pain.

@ogregoire
Copy link
Collaborator Author

@bagelbits yes it's feasible but I don't know how I could do it so that I spend less time on it than manually modifying each value. JavaScript would be a good candidate, but I'm not fluent with it. Also the URL must be adapted. And actually, this is why having unrelated numbers as keys is a bad idea. Every time we're gonna modify the number of elements in an array, we're gonna have to keep the numbers up to date. That's really not easy. But yes, I can do it. I'll try when I have time this week.

@bagelbits
Copy link
Collaborator

@ogregoire If you want, I can do this as a separate PR. I can probably brew up a quick script to clean it up. Feel free to cut an issue and assign it to me.

Copy link
Collaborator

@bagelbits bagelbits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogregoire
Copy link
Collaborator Author

I updated the file with the new indices. As I said, it wasn't easy. But I managed to to it.

@bagelbits
Copy link
Collaborator

I'm really sorry for making you do that. I'll try to figure out a better way to do that in the future. If I ever ask that again, make me write a script for you.

@bagelbits bagelbits merged commit e0af06e into 5e-bits:master Dec 10, 2019
@ogregoire
Copy link
Collaborator Author

I'm really sorry for making you do that. I'll try to figure out a better way to do that in the future. If I ever ask that again, make me write a script for you.

You shouldn't be sorry. I need to up my game with regards to automated changes. Currently, all the changes I do on this repo are done using regex searches and replacements.

Being a Java programmer, Json is hard to parse and several libraries are just doing too much, not giving access to basic Json functionality. I had to copy a library source code, and adapt it to not mess up the ordering of fields. But now it's done and it's in my tool box.

@ogregoire ogregoire deleted the remove-non-srd-monsters branch January 2, 2020 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-SRD monsters should be removed
2 participants