removing some warnings

710lucas · Aug 5, 2024 · 4d2448b · 4d2448b
1 parent 6053a66
commit 4d2448b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/emulator/cpu.cpp b/src/emulator/cpu.cpp
@@ -63,8 +63,8 @@ int Cpu::cycle(){
         byte instruction = this->bus.readData();
 
 
-        if(instruction == NULL){
-            std::cerr<<"Invalid instruction" << static_cast<int>(instruction) << "\n";
+        if(instruction == 0){
+            std::cerr<<"Invalid instruction\n" << "PC: "<< pc << "\n";
             return -1;
         }
 

diff --git a/src/emulator/cpu.h b/src/emulator/cpu.h
@@ -3,6 +3,7 @@
 #include <stdio.h>
 #include <cstdint>
 #include <iostream>
+#include <limits.h>
 #include "./BUS/bus_module/busModule.hpp"
 #include "./stack/stack.h"
 #include "./BUS/systemBus.hpp"
@@ -20,8 +21,8 @@ class Cpu{
 
     long pc = 0;
 
-    const int maxValue = (1 << (sizeof(int) * 8 - 1)) - 1;
-    const int minValue = -(1 << (sizeof(short) * 8 - 1));
+    const long maxValue = INT_MAX;
+    const long minValue = INT_MIN;
 
     Stack stack = Stack();