Store the CompressOptions struct on the stack #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of having an instance variable for CompressOptions it's now put on the stack. The struct is as of current version only used to indicate if the buffer passed to compress_update is stable (is there for the next call to compress_update, or not). flush and compress_end does not use the struct as of today, so nil can be passed instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Optimization and clarity
WHAT is this pull request doing?
Instead of having an instance variable for CompressOptions it's now put on the stack. The struct is as of current version only used to indicate if the buffer passed to compress_update is stable (is there for the next call to compress_update, or not). flush and compress_end does not use the struct as of today, so nil can be passed instead.
HOW can this pull request be tested?
specs