Skip to content

Commit

Permalink
Merge pull request #15 from A2-ai/interactive_gert_fix
Browse files Browse the repository at this point in the history
fixing bug which did not allow for gert to not be instaled
  • Loading branch information
jenna-a2ai authored Nov 14, 2024
2 parents 73729e4 + d039c0e commit 4a610c4
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: ghqc
Title: Manage QC via GitHub Issues using Shiny Apps
Version: 0.1.7
Version: 0.1.8
Authors@R: c(
person("Anne", "Zheng", email = "[email protected]", role = c("aut")),
person("Jenna", "Johnson", email = "[email protected]", role = c("aut")),
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# ghqc 0.1.8

- The logic for rejecting `gert` install as part of `setup_ghqc` was incorrect. Updating to allow for rejection

# ghqc 0.1.7

- typo found in `setup_ghqc` related to the info repo global variable. No performance change
Expand Down
2 changes: 1 addition & 1 deletion R/interactive_setup.R
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ interactive_info_download <- function() {
cli::cli_inform(c("!" = "Package {.code gert} is not found in your project package library",
" " = "The configuration information repository cannot be downloaded unless this package is present"))
yN <- gsub('\"', "", readline("Would you like to install `gert` to continue? (y/N) "))
if (yN != "y" && yN == "") {
if (yN != "y" || yN == "") {
cli::cli_alert_danger("`gert` is not installed. Configuring information repository cannot be checked or downloaded using this package")
return(invisible())
}
Expand Down

0 comments on commit 4a610c4

Please sign in to comment.