Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No checklist directory error handling #2

Merged
merged 6 commits into from
Oct 29, 2024
Merged

No checklist directory error handling #2

merged 6 commits into from
Oct 29, 2024

Conversation

wes-a2ai
Copy link
Collaborator

A bug was found when attempting to clone a configuration information repository which did not contain a "checklist" directory due to an fs::dir_ls() call without checking if the directory exists before hand. Warning/communication if the checklist directory doesn't exist or is empty exists elsewhere in the code, so adding a verification step before listing the content within the directory helps to invoke that warning.

Additionally, creating a flag to force a new download of the configuration information repository within the download_ghqc_information function

@wes-a2ai wes-a2ai requested a review from jenna-a2ai October 28, 2024 20:51
@jenna-a2ai
Copy link
Collaborator

Checklists dir dne locally:

sitrep

Screenshot 2024-10-29 at 10 51 52 AM

setup

Screenshot 2024-10-29 at 11 00 50 AM

Checklists dir dne remotely (cloning in for first time)

sitrep

Screenshot 2024-10-29 at 10 56 55 AM

setup

Here I:

  • changed my renviron manually to a info repo that dne exist locally
  • ran setup_ghqc

sitrep worked because it checked if the repo was local first, I think, but setup doesn't
Screenshot 2024-10-29 at 10 58 11 AM

@jenna-a2ai
Copy link
Collaborator

Small grammar note:

Screenshot 2024-10-29 at 11 41 25 AM

@jenna-a2ai
Copy link
Collaborator

problem was parsing env var without "" in Renviron: fixed!

Screenshot 2024-10-29 at 1 26 27 PM

@jenna-a2ai
Copy link
Collaborator

Success:

Screenshot 2024-10-29 at 1 44 09 PM Screenshot 2024-10-29 at 1 45 08 PM

@wes-a2ai
Copy link
Collaborator Author

Small grammar note:

Screenshot 2024-10-29 at 11 41 25 AM

Fixed in ghqc.app

@jenna-a2ai jenna-a2ai merged commit fd8c8dc into main Oct 29, 2024
3 checks passed
@wes-a2ai wes-a2ai deleted the no_checklist_dir branch October 29, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants