Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CM3 meltpond coupling #14

Merged
merged 3 commits into from
Jan 28, 2025
Merged

Add CM3 meltpond coupling #14

merged 3 commits into from
Jan 28, 2025

Conversation

blimlim
Copy link

@blimlim blimlim commented Jan 22, 2025

This pull request adds the CICE changes required for coupling meltponds in CM3. See ACCESS-NRI/dev_coupling#37 for discussion behind these changes and results from short simulations.

Changes in this PR include:

  • aborting from the access driver if tr_pond_lvl=.true.. This is done as apeffn is not calculated when tr_pond_lvl=.true. and calc_Tsfc=.False. (see here
  • Pond fractions are scaled by ice fractions and pond depths are scaled by pond grid-cell fractions prior to exporting. This is done to produce sensible averages which preserve pond areas and volumes after unscaling in the atmosphere.

@blimlim blimlim requested a review from kieranricardo January 28, 2025 03:21
kieranricardo
kieranricardo approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@kieranricardo kieranricardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - nice work!

@blimlim
Copy link
Author

blimlim commented Jan 28, 2025

Thanks for the review @kieranricardo! Merging now

@blimlim blimlim merged commit 5151c0b into cm3-coupling Jan 28, 2025
1 check failed
@blimlim blimlim deleted the meltpond-coupling branch January 28, 2025 05:38
@kieranricardo kieranricardo mentioned this pull request Jan 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kieranricardo kieranricardo kieranricardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blimlim @kieranricardo